Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ref flags for function params/locals to AOT module instead of committing them in GC AOT code #2990

Merged
merged 7 commits into from
Jan 12, 2024
Merged

Add ref flags for function params/locals to AOT module instead of committing them in GC AOT code #2990

merged 7 commits into from
Jan 12, 2024

Conversation

TianlongLiang
Copy link
Contributor

No description provided.

@TianlongLiang TianlongLiang marked this pull request as draft January 9, 2024 03:45
@TianlongLiang TianlongLiang marked this pull request as ready for review January 10, 2024 05:45
wenyongh
wenyongh reviewed Jan 11, 2024
View reviewed changes
core/iwasm/aot/aot_loader.c Outdated Show resolved Hide resolved
core/iwasm/aot/aot_runtime.h Outdated Show resolved Hide resolved
core/iwasm/aot/aot_loader.c Show resolved Hide resolved
core/iwasm/aot/aot_runtime.h Outdated Show resolved Hide resolved
core/iwasm/compilation/aot_compiler.c Outdated Show resolved Hide resolved
core/iwasm/compilation/aot_compiler.c Outdated Show resolved Hide resolved
xujuntwt95329
xujuntwt95329 reviewed Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@xujuntwt95329 xujuntwt95329 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit a74839a into bytecodealliance:dev/gc_refactor Jan 12, 2024
404 checks passed
@TianlongLiang TianlongLiang deleted the dev/aot_local_ref_flags branch February 22, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyongh wenyongh wenyongh left review comments

@xujuntwt95329 xujuntwt95329 xujuntwt95329 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TianlongLiang @xujuntwt95329 @wenyongh