Check arguments before calling bh_hash_map_find #3055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamt
reviewed
Jan 19, 2024
| @@ -176,7 +176,7 @@ acquire_wait_info(void *address, AtomicWaitNode *wait_node) | |||
| AtomicWaitInfo *wait_info = NULL; | |||
| bh_list_status ret; | |||
|
|
|||
| if (address) | |||
| if (wait_map && address) /* avoid passing NULL to bh_hash_map_find */ | |||
There was a problem hiding this comment.
as far as i understand, "address" here can't be NULL.
There was a problem hiding this comment.
Yes, you are right, here the address comes from opcode atomic.wait32, atomic.wait64 and atomic.notify, all of them operate on an address inside the linear memory, which should not be NULL. I changed to bh_assert instead.
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Check whether the arguments are NULL before calling bh_hash_map_find, or lots of "HashMap find elem failed: map or key is NULL" warnings may be dumped. Reported in bytecodealliance#3053.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check whether the arguments are NULL before calling bh_hash_map_find,
or lots of "HashMap find elem failed: map or key is NULL" warnings may
be dumped. Reported in #3053.