Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm_cluster_destroy_spawned_exec_env: avoid "invalid exec env" trap #3068

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

yamt
Copy link
Collaborator

@yamt yamt commented Jan 22, 2024

Possible alternatives:

Possible alternatives:

* Make wasm_cluster_destroy_spawned_exec_env take two exec_env.
  One for wasm execution and another to specify the target to destroy.

* Make execute functions to switch exec_env as briefly discussed in
  bytecodealliance#2047
@yamt
Copy link
Collaborator Author

yamt commented Jan 22, 2024

the windows ci failure looks like #2776

two macos job failures look unrelated too.

Warning: Failed to download action 'https://api.github.com/repos/actions/cache/tarball/e12d46a63a90f2fae62d114769bbf2a179198b5c'. Error: nodename nor servname provided, or not known (codeload.github.com:443)
Warning: Back off 12.507 seconds before retry.
Warning: Failed to download action 'https://api.github.com/repos/actions/cache/tarball/e12d46a63a90f2fae62d114769bbf2a179198b5c'. Error: Operation timed out (api.github.com:443)
Warning: Back off 21.768 seconds before retry.
Error: nodename nor servname provided, or not known (api.github.com:443)
Download action repository 'actions/cache@v3' (SHA:e12d46a63a90f2fae62d114769bbf2a179198b5c)
Warning: Failed to download action 'https://api.github.com/repos/actions/cache/tarball/e12d46a63a90f2fae62d114769bbf2a179198b5c'. Error: nodename nor servname provided, or not known (api.github.com:443)
Warning: Back off 11.773 seconds before retry.
Warning: Failed to download action 'https://api.github.com/repos/actions/cache/tarball/e12d46a63a90f2fae62d114769bbf2a179198b5c'. Error: nodename nor servname provided, or not known (api.github.com:443)
Warning: Back off 24.281 seconds before retry.
Error: nodename nor servname provided, or not known (api.github.com:443)

@wenyongh wenyongh merged commit ab97d54 into bytecodealliance:main Jan 23, 2024
407 checks passed
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
…ytecodealliance#3068)

Possible alternatives:

* Make wasm_cluster_destroy_spawned_exec_env take two exec_env.
  One for wasm execution and another to specify the target to destroy.

* Make execute functions to switch exec_env as briefly discussed in
  bytecodealliance#2047
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants