-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Exception Handling for classic interpreter #3096
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define exception handling opcodes and add empty handlers for the opcodes.
Merge branch main into dev/exce_handling
Merge branch main into dev/exce_handling
Merge branch main into dev/exce_handling
Merge branch main into dev/exce_handling
Merge branch main into dev/exce_handling
Merge branch main into dev/exce_handling
Merge branch main into dev/exce_handling
This PR adds the initial support for WASM exceptions, it is an initial contribution, as part 1 of 2 contributions. Refer to: #2382 ### Included in this contribution * Inside the classic interpreter only: * Initial handling of Tags * Initial handling of Exceptions based on W3C Exception Proposal * Add `cmake -DWAMR_BUILD_EXCE_HANDLING=1/0` option to enable/disable the feature, and update the wamr-test-suites scripts to test the feature. ### To be included in Part 2 * Inside the classic interpreter only: * Bug fixes and naming convention improvements * Additional CI /CD changes to validate ENABLE_EXCE_HANDLING switch builds OK on all platforms * Import and Export of Exceptions and Tags Signed-off-by: Chris Woods <chris.woods@siemens.com> Co-authored-by: Ricardo Aguilar <ricardoaguilar@siemens.com> Co-authored-by: Rene Ermler <rene.ermler@siemens.com>
Merge branch main into dev/exce_handling
This PR continues the work from #2382 and updates the exception handling support: * Inside the classic interpreter only: * Bug fixes and naming convention improvements * Import and Export of Exceptions and Tags * Remove the dependency on multi-module * Additional CI /CD changes to validate ENABLE_EXCE_HANDLING switch builds OK on all platforms Refer to #1884. Signed-off-by: Ricardo Aguilar <ricardoaguilar@siemens.com> Co-authored-by: Chris Woods <chris.woods@siemens.com> Co-authored-by: Rene Ermler <rene.ermler@siemens.com> Co-authored-by: Trenner Thomas <trenner.thomas@siemens.com>
Merge branch main into dev/exce_handling
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…e#3096) This PR adds the initial support for WASM exception handling: * Inside the classic interpreter only: * Initial handling of Tags * Initial handling of Exceptions based on W3C Exception Proposal * Import and Export of Exceptions and Tags * Add `cmake -DWAMR_BUILD_EXCE_HANDLING=1/0` option to enable/disable the feature, and by default it is disabled * Update the wamr-test-suites scripts to test the feature * Additional CI/CD changes to validate the exception spec proposal cases Refer to: bytecodealliance#1884 bytecodealliance@587513f bytecodealliance@8bebfe9 bytecodealliance@59bccdf Signed-off-by: Ricardo Aguilar <ricardoaguilar@siemens.com> Co-authored-by: Chris Woods <chris.woods@siemens.com> Co-authored-by: Rene Ermler <rene.ermler@siemens.com> Co-authored-by: Trenner Thomas <trenner.thomas@siemens.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge branch dev/exce_handling to main to support exception handling,
currently it only supports classic interpreter mode, and is still in highly
experimental stage.
Refer to:
587513f
8bebfe9
59bccdf