Fix inconsistent coding convention #3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no1wudi
changed the title
wenyongh
reviewed
Feb 21, 2024
| @@ -232,14 +232,14 @@ destroy_wait_info(void *wait_info) | |||
| } | |||
|
|
|||
| static void | |||
| map_try_release_wait_info(HashMap *wait_map_, AtomicWaitInfo *wait_info, | |||
| map_try_release_wait_info(HashMap *wait_map, AtomicWaitInfo *wait_info, | |||
There was a problem hiding this comment.
This argument may shadow the variable defined in L44 and cause compilation warning, had better use other name here.
There was a problem hiding this comment.
Or how about removing this argument, as this function is only called by wasm_runtime_atomic_wait, which always passes the global wait_map to this function.
There was a problem hiding this comment.
Fixed, but it's strange, my compiler don't report the shadowing
There was a problem hiding this comment.
Yes, maybe it is only reported by some compiler.
wenyongh
approved these changes
Feb 22, 2024
wenyongh
added a commit
that referenced
this pull request
Apr 3, 2024
Apply patches which were fixed branch main to branch `release/1.3.x`: - zephyr: Use zephyr sys_cache instead of CMSIS (#3162) - Fix llvm jit push funcref/externref result type issue (#3169) - Fix inconsistent coding convention (#3171) - VSCode IDE enhancement and readme update (#3172) - zephyr: include math only with minimal libc (#3177) - Fix wasm loader handling opcode br_table (#3176) - Specify language in the wasi socket ext project (#3183) - lldb_function_to_function_dbi: Fix a null dereference (#3189) - Fix LLVM assertion failure and update CONTRIBUTING.md (#3197) - lldb_function_to_function_dbi: A hack to avoid crashing on C++ methods (#3190) - Fix compilation errors on MinGW (#3217) - Fix compilation errors on esp-idf platform (#3224) - Fix aot relocation symbols not found on windows 32-bit (#3231) - Fix nightly run tsan ASLR issue (#3233) - Go binding: Change C.long to C.int64_t when call wasm_runtime_set_wasi_args_ex (#3235) - posix_file.c: Correct the dirfd argument that passes to fstatat (#3244) - Fix compilation errors on zephyr platform (#3255) - Fix dynamic offset not updated in op_br for block with ret type (#3269) - Fix CI error when install packages for macos-14 (#3270)
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.