Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo for 'native' in wasm_export.h #3376

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Fix typo for 'native' in wasm_export.h #3376

merged 1 commit into from
Apr 30, 2024

Conversation

bnason-nf
Copy link
Contributor

Trivial spelling fix.

@wenyongh wenyongh mentioned this pull request Apr 30, 2024
Merged
@wenyongh wenyongh merged commit 4abf288 into bytecodealliance:main Apr 30, 2024
376 checks passed
wenyongh added a commit that referenced this pull request May 1, 2024
@wenyongh
aot compiler: Fix the length type passed to aot_memmove/aot_memset (#…
835188c 
…3378)

The current length type of aot_memmove/aot_memset is size_t, and on
a 64 bit host it is uint64, while what the aot code passes to it is uint32,
this might lead to unexpected behavior.

ps. #3376.
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 1, 2024
@bnason-nf @victoryang00
Fix typo for 'native' in wasm_export.h (bytecodealliance#3376)
9592515 
Trivial spelling fix.
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 1, 2024
@wenyongh @victoryang00
aot compiler: Fix the length type passed to aot_memmove/aot_memset (b…
ef20159 
…ytecodealliance#3378)

The current length type of aot_memmove/aot_memset is size_t, and on
a 64 bit host it is uint64, while what the aot code passes to it is uint32,
this might lead to unexpected behavior.

ps. bytecodealliance#3376.
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 2, 2024
@bnason-nf @victoryang00
Fix typo for 'native' in wasm_export.h (bytecodealliance#3376)
9674438 
Trivial spelling fix.

Signed-off-by: victoryang00 <victoryang00@ucsc.edu>
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 2, 2024
@wenyongh @victoryang00
aot compiler: Fix the length type passed to aot_memmove/aot_memset (b…
4dbed20 
…ytecodealliance#3378)

The current length type of aot_memmove/aot_memset is size_t, and on
a 64 bit host it is uint64, while what the aot code passes to it is uint32,
this might lead to unexpected behavior.

ps. bytecodealliance#3376.

Signed-off-by: victoryang00 <victoryang00@ucsc.edu>
@bnason-nf bnason-nf deleted the fix-native-spelling branch May 6, 2024 19:59
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@bnason-nf @victoryang00
Fix typo for 'native' in wasm_export.h (bytecodealliance#3376)
8817cff 
Trivial spelling fix.

Signed-off-by: victoryang00 <victoryang00@ucsc.edu>
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@wenyongh @victoryang00
aot compiler: Fix the length type passed to aot_memmove/aot_memset (b…
377af6c 
…ytecodealliance#3378)

The current length type of aot_memmove/aot_memset is size_t, and on
a 64 bit host it is uint64, while what the aot code passes to it is uint32,
this might lead to unexpected behavior.

ps. bytecodealliance#3376.

Signed-off-by: victoryang00 <victoryang00@ucsc.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyongh wenyongh wenyongh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnason-nf @wenyongh