Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an Android build failure because
getrandom()
is not declared. I was specifically using Android NDK 24, andgetrandom()
was not available in the NDK until version 28.I am not an export on the Android platform, but based on the thread below it looks like the preferred preprocessor check for Android is
__ANDROID__
instead ofANDROID
:https://groups.google.com/g/android-ndk/c/cf9_f1SLXls
However it looks like maybe there are cases where the one without underscores is necessary, so this change just checks for either one. This causes
CONFIG_HAS_ARC4RANDOM_BUF
to be set to 1 for either Android preprocessor define, and in turn to usearc4random_buf()
instead ofgetrandom()
.