Clone data segments when specified with load args #3463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloparco
force-pushed
the
eloparco/clone-data-segments
branch
from
333792b
to
bade8a7
Compare
wenyongh
reviewed
May 23, 2024
eloparco
force-pushed
the
eloparco/clone-data-segments
branch
2 times, most recently
from
4cb67c2
to
90bd42a
Compare
wenyongh
reviewed
May 23, 2024
eloparco
force-pushed
the
eloparco/clone-data-segments
branch
from
90bd42a
to
4f5c51c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #3389, specifically: #3389 (comment)
If we want to free the wasm binary buffer early, we need to clone the data segments into the module. That's because, in case of passive data segments, they can be referred during wasm execution.