Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix posix no libc wasi debug interp build #3503

Merged

Conversation

bnason-nf
Copy link
Contributor

This change supports building with WAMR_BUILD_LIBC_WASI=0 and WAMR_BUILD_DEBUG_INTERP=1, otherwise the os_socket_* functions will be undefined.

@bnason-nf
Copy link
Contributor Author

bnason-nf commented Jun 5, 2024

Hi @wenyongh, yes, the intention is for the else() clause to be different. The reason is that when we are building with WAMR_BUILD_DEBUG_INTERP=1, we want to compile posix_socket.c, and we also want to use platform_common_libc_util.cmake regardless of the setting of WAMR_BUILD_LIBC_WASI. I tested all four combinations of WAMR_BUILD_LIBC_WASI and WAMR_BUILD_DEBUG_INTERP before submitting this pull request, so unless I made a mistake I think this is behaving as intended.

@wenyongh
Copy link
Contributor

wenyongh commented Jun 6, 2024

Hi @wenyongh, yes, the intention is for the else() clause to be different. The reason is that when we are building with WAMR_BUILD_DEBUG_INTERP=1, we want to compile posix_socket.c, and we also want to use platform_common_libc_util.cmake regardless of the setting of WAMR_BUILD_LIBC_WASI. I tested all four combinations of WAMR_BUILD_LIBC_WASI and WAMR_BUILD_DEBUG_INTERP before submitting this pull request, so unless I made a mistake I think this is behaving as intended.

OK, got it, thanks.

Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit 421a6c4 into bytecodealliance:main Jun 6, 2024
378 checks passed
@bnason-nf bnason-nf deleted the fix-posix-no-libc-wasi-debug-build branch June 6, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants