Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Android pthread linkage #3591

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Fix Android pthread linkage #3591

merged 2 commits into from
Jul 4, 2024

Conversation

bnason-nf
Copy link
Contributor

No description provided.

yamt
yamt requested changes Jul 2, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@bnason-nf bnason-nf changed the title Only link pthread lib for WAMR_BUILD_LIB_PTHREAD Fix Android pthread linkage Jul 3, 2024
wenyongh
wenyongh approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yamt
yamt approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@yamt yamt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wenyongh wenyongh merged commit 7771212 into bytecodealliance:main Jul 4, 2024
1 check passed
@bnason-nf bnason-nf deleted the make-pthread-optional branch July 5, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyongh wenyongh wenyongh approved these changes

@yamt yamt yamt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnason-nf @yamt @wenyongh