Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOT: Fix NaN handling for f32/f64 const op #3721

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

no1wudi
Copy link
Collaborator

@no1wudi no1wudi commented Aug 15, 2024

If the value of a float constant is NaN, it will not be handed correctly by f32.const or f64.const, then it may cause a relocation in the AOT file.

@no1wudi no1wudi force-pushed the riscv branch 3 times, most recently from 521b094 to bbb76ad Compare August 15, 2024 11:24
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except a minor comment

core/iwasm/compilation/aot_emit_const.c Outdated Show resolved Hide resolved
@no1wudi no1wudi force-pushed the riscv branch 5 times, most recently from 0fcf99a to eeca2d6 Compare August 16, 2024 04:37
If the value of a float constant is NaN, it will not be handed correctly by
f32.const or f64.const, then it may cause a relocation in the AOT file.
@wenyongh wenyongh merged commit 4c12771 into bytecodealliance:main Aug 16, 2024
387 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants