Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for building iwasm_shared and iwasm_static libs on win32 #3762

Merged
merged 9 commits into from
Sep 6, 2024
Merged

Fixes for building iwasm_shared and iwasm_static libs on win32 #3762

merged 9 commits into from
Sep 6, 2024

Conversation

mattyg
Copy link
Contributor

@mattyg mattyg commented Aug 31, 2024 •
edited
Loading

Fixes to enable building iwasm_shared and iwasm_static libraries on win32. Still doesn't work the default build flags, but works for mine:

cmake .. -DWAMR_BUILD_AOT=0 -DWAMR_BUILD_BULK_MEMORY=1 -DWAMR_BUILD_REF_TYPES=1 -DWAMR_BUILD_SIMD=1 -DWAMR_BUILD_LIB_PTHREAD=1 -DWAMR_BUILD_LIB_WASI_THREADS=0 -DWAMR_BUILD_LIBC_WASI=0 -DWAMR_BUILD_LIBC_BUILTIN=0 -DWAMR_BUILD_SHARED_MEMORY=1 -DWAMR_BUILD_MULTI_MODULE=0 -DWAMR_DISABLE_HW_BOUND_CHECK=1```

@mattyg mattyg changed the title Fix/msvc compile of lib Fixes for building iwasm_shared and iwasm_static libs on win32 Aug 31, 2024
@mattyg mattyg mentioned this pull request Sep 1, 2024
Open
wenyongh
wenyongh reviewed Sep 3, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
wenyongh
wenyongh reviewed Sep 5, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
wenyongh
wenyongh approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit b38a2e8 into bytecodealliance:main Sep 6, 2024
1 check passed
bnason-nf added a commit to bnason-nf/wasm-micro-runtime that referenced this pull request Sep 16, 2024
@bnason-nf
Restore cmake hidden compile symbol visibility
442a2b5 
This was originally fixed in bytecodealliance#3655, but regressed in bytecodealliance#3762 which removed
the -fvisibility=hidden flag from the CMakeLists.txt file.

This also removes extraneous ending whitespace from the file.
@bnason-nf bnason-nf mentioned this pull request Sep 16, 2024
Merged
wenyongh pushed a commit that referenced this pull request Sep 18, 2024
@bnason-nf
Restore cmake hidden compile symbol visibility (#3796)
e9cc873 
This was originally fixed in #3655, but regressed in #3762 which removed
the `-fvisibility=hidden` flag from the CMakeLists.txt file.

This also removes extraneous ending whitespace from the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyongh wenyongh wenyongh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattyg @wenyongh