-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support dynamic aot debug #3788
Conversation
d772680
to
ef489b7
Compare
@yamt hi. you can see this PR, thank you for your attention. |
Signed-off-by: zhangliangyu3 <zhangliangyu3@xiaomi.com>
./wamrc --opt-level=0 --format=object --target=thumbv7 --target-abi=gnueabihf --cpu=cortex-a7 --cpu-features=-neon -o test test.wasm | ||
``` | ||
|
||
#### 3. Start emulator and nuttx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should support natvie iwasm or other platform, add lease the native iwasm guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it would be highly appreciated if a document and an example are provided for native iwasm. For example, in Ubuntu/MacOS, compile a simple C app to wasm and then to the AOT file, and then demonstrate how to set the break point at a line of C source and view or dump the call stack.
|
||
- build test.wasm to test.aot | ||
|
||
Compile and generate the test.aot file using wamrc without WAMR_BUILD_DEBUG_AOT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why is this step needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(⊙o⊙)…
because the WAMR_BUILD_DEBUG_AOT macro wasn't enabled when compiling iwasm. If you enable it now, it might cause issues when running test.aot with iwasm.
product-mini/platforms/posix/main.c
Outdated
sizeof(error_buf))) { | ||
printf("set aot module name failed in dynamic aot debug mode, %s\n", | ||
error_buf); | ||
goto fail2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be goto fail3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
./wamrc --opt-level=0 --format=object --target=thumbv7 --target-abi=gnueabihf --cpu=cortex-a7 --cpu-features=-neon -o test test.wasm | ||
``` | ||
|
||
#### 3. Start emulator and nuttx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it would be highly appreciated if a document and an example are provided for native iwasm. For example, in Ubuntu/MacOS, compile a simple C app to wasm and then to the AOT file, and then demonstrate how to set the break point at a line of C source and view or dump the call stack.
|
||
#### 2.1 Build wamrc Compiler | ||
|
||
Ensure that wamrc is built with the WAMR_BUILD_DEBUG_AOT flag enabled. You can find the wamrc compiler [here](https://github.com/bytecodealliance/wasm-micro-runtime/tree/main/wamr-compiler) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about changing the last sentence to Please refer to the first two steps in [doc/source_debugging_aot.md](../../doc/source_debugging_aot.md).
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c6f96bd
to
3539b26
Compare
No description provided.