Refactor shared heap feature for interpreter mode #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenLY1
reviewed
Sep 14, 2024
core/iwasm/common/wasm_memory.c
Outdated
| if (heap) { | ||
| mem_allocator_free(heap->base_addr, addr); | ||
| if (memory->is_memory64) { | ||
| if (ptr < shared_heap->start_off_mem64) |
There was a problem hiding this comment.
If native addr is not in shared heap, it's better to throw an error?
core/iwasm/common/wasm_memory.c
Outdated
| } | ||
|
|
||
| #if WASM_ENABLE_SHARED_HEAP != 0 | ||
| if (is_app_addr_in_shared_heap(module_inst_comm, memory_inst->is_memory64, |
There was a problem hiding this comment.
If the app_offset is in shared heap, it's seems that the check will go to fail at line 659, and is_app_addr_in_shared_heap will not work. Move this before line 657?
There was a problem hiding this comment.
yes, thanks, done.
wenyongh
added a commit
to wenyongh/wasm-micro-runtime
that referenced
this pull request
Sep 19, 2024
Refactor shared heap feature for interpreter mode (bytecodealliance#3794)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.