-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump AOT_CURRENT_VERSION for WAMR 2.x (gc, memory64) #3880
Merged
lum1n0us
merged 2 commits into
bytecodealliance:main
from
yamt:bump-AOT_CURRENT_VERSION
Oct 29, 2024
Merged
Bump AOT_CURRENT_VERSION for WAMR 2.x (gc, memory64) #3880
lum1n0us
merged 2 commits into
bytecodealliance:main
from
yamt:bump-AOT_CURRENT_VERSION
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe it's too late because we have already made a few releases since then. But this might still help users who haven't upgraded to WAMR 2.x yet. Also, for the purpose of the versioning, it's safer to bump needlessly than missing necessary bumps. Fixes bytecodealliance#3837
yamt
requested review from
loganek,
lum1n0us,
no1wudi,
wenyongh and
xujuntwt95329
as code owners
October 24, 2024 03:51
wenyongh
approved these changes
Oct 29, 2024
LGTM |
lum1n0us
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lum1n0us
added a commit
to lum1n0us/wasm-micro-runtime
that referenced
this pull request
Oct 29, 2024
This commit refactors the AOT loader in `aot_loader.c` to support compatible versions of the AOT_CURRENT_VERSION constant. Previously, the loader only accepted the exact AOT_CURRENT_VERSION value, but now it also accepts version 3. This change ensures that the runtime can load modules AoT-compiled with different versions of wamrc as long as they have compatible AOT_CURRENT_VERSION values. Related to bytecodealliance#3880
lum1n0us
added a commit
to lum1n0us/wasm-micro-runtime
that referenced
this pull request
Oct 30, 2024
This commit refactors the AOT loader in `aot_loader.c` to support compatible versions of the AOT_CURRENT_VERSION constant. Previously, the loader only accepted the exact AOT_CURRENT_VERSION value, but now it also accepts version 3. This change ensures that the runtime can load modules AoT-compiled with different versions of wamrc as long as they have compatible AOT_CURRENT_VERSION values. Related to bytecodealliance#3880
wenyongh
pushed a commit
that referenced
this pull request
Nov 1, 2024
This commit refactors the AOT loader in `aot_loader.c` to support compatible versions of the AOT_CURRENT_VERSION constant. Previously, the loader only accepted the exact AOT_CURRENT_VERSION value, but now it also accepts version 3. This change ensures that the runtime can load modules AoT-compiled with different versions of wamrc as long as they have compatible AOT_CURRENT_VERSION values. Related to #3880.
lum1n0us
added a commit
that referenced
this pull request
Nov 20, 2024
* Exclude fuzz test python and npm packages in scoreboard scan (#3871) * Fix out of bounds issues after memory.grow on non-aot non-threads builds (#3872) * fix(ios): Remove `float-abi` flag (#3889) * build(deps): bump github/codeql-action from 3.26.13 to 3.27.0 (#3888) * Refine looking up aot function with index (#3882) * Bump AOT_CURRENT_VERSION for WAMR 2.x (gc, memory64) (#3880) * Fix mmap flags for AOT loader on non-Linux SGX platforms (#3890) * Fix out of bounds issue in is_native_addr_in_shared_heap function (#3886) * Refactor AOT loader to support compatible versions (#3891) * Wasm loader enhancement: check code size in code entry (#3892) * Fix linked global initialization in multimodule (#3905) * build(deps): bump github/codeql-action from 3.27.0 to 3.27.1 (#3902) * GlobalValueSet was moved to IRPartitionLayer recently, but we have a local definition anyway (#3899) * Fix a leak in wasm_loader_emit_br_info (#3900) * Correct the table index calculation in aot_instantiation (#3903) * build(deps): bump github/codeql-action from 3.27.1 to 3.27.4 (#3912) * Support external toolchain on Windows for aot compiler (#3911) * Fix CI wamr-ide error (#3913) Co-authored-by: TianlongLiang <111852609+TianlongLiang@users.noreply.github.com> Co-authored-by: Maks Litskevich <makslit@amazon.com> Co-authored-by: Deniz Sokmen <dsokmen@amazon.com> Co-authored-by: edoardo <48774736+xdoardo@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: YAMAMOTO Takashi <yamamoto@midokura.com> Co-authored-by: liang.he <liang.he@intel.com> Co-authored-by: Fadumina Barre <bafadumi@amazon.com> Co-authored-by: Marcin Kolny <mkolny@amazon.com> Co-authored-by: James Ring <sjr@jdns.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe it's too late because we have already made a few releases since then.
But this might still help users who haven't upgraded to WAMR 2.x yet. Also, for the purpose of the versioning, it's safer to bump needlessly than missing necessary bumps.
Fixes #3837