Implement invokeNative asm code for armasm64 assembler on ARM64 Windows#4636
Merged
lum1n0us merged 2 commits intobytecodealliance:mainfrom Oct 9, 2025
Merged
Conversation
cosmo0920
requested review from
TianlongLiang,
loganek,
lum1n0us,
no1wudi,
wenyongh,
xujuntwt95329 and
yamt
as code owners
cosmo0920
force-pushed
the
add-arm64-windows-assemblies
branch
from
8c0b5a0 to
adbb644
Compare
TianlongLiang
approved these changes
Sep 23, 2025
Contributor
TianlongLiang
left a comment
TianlongLiang
left a comment
There was a problem hiding this comment.
Code LGTM, would you mind rebase after #4633?
Contributor
Author
Sure thing. Today is a public holiday here. So, I'll process tomorrow. |
Signed-off-by: Hiroshi Hatake <cosmo0920.oucc@gmail.com>
Signed-off-by: Hiroshi Hatake <cosmo0920.oucc@gmail.com>
cosmo0920
force-pushed
the
add-arm64-windows-assemblies
branch
from
adbb644 to
f27b2c0
Compare
Contributor
Author
|
I rebased off the current main. So, CI tasks are all succeeded. |
lum1n0us
approved these changes
Oct 9, 2025
lum1n0us
added
the
new feature
kr-t
pushed a commit
to project-ocre/wasm-micro-runtime
that referenced
this pull request
Nov 13, 2025
…ws (bytecodealliance#4636) * Implement invokeNative asm code for armasm64 assembler on ARM64 Windows * Use more solid wrapper for armasm64 executable Signed-off-by: Hiroshi Hatake <cosmo0920.oucc@gmail.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ARM64 Windows, we need to use armasm64.exe instead of ml.exe.
So, we need to specify it manually inside of cmake files.
Fixes #4609.