-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workspace: Remove wasmparser::Operator
type usage
#711
Comments
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this issue
Aug 11, 2022
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this issue
Aug 15, 2022
alexcrichton
added a commit
that referenced
this issue
Aug 15, 2022
* Remove usage of `Operator` in `wasm-tools dump` cc #711 * Remove `op:` prefix
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this issue
Aug 16, 2022
This also reorders methods in the trait definition to match the order they're defined in the spec to try to organize things together a bit more. cc bytecodealliance#711
alexcrichton
added a commit
that referenced
this issue
Aug 17, 2022
This also reorders methods in the trait definition to match the order they're defined in the spec to try to organize things together a bit more. cc #711
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this issue
Aug 18, 2022
This commit updates the `check_const_expr` function to remove the usage of the `Operator` visitor in the spirit of eventually removing the `Operator` type if possible. This was achieved through some macro-magic and isn't necessarily more readable than the prior version, so I could see this going either way. In the long run with bytecodealliance#733 it's not really difficult per-se to maintain an `Operator` interface in `wasmparser` since it's trivially defined via macros. This may be a case where we want to use that more than the `visit_*` pieces perhaps. cc bytecodealliance#711
fitzgen
pushed a commit
that referenced
this issue
Aug 18, 2022
This commit updates the `check_const_expr` function to remove the usage of the `Operator` visitor in the spirit of eventually removing the `Operator` type if possible. This was achieved through some macro-magic and isn't necessarily more readable than the prior version, so I could see this going either way. In the long run with #733 it's not really difficult per-se to maintain an `Operator` interface in `wasmparser` since it's trivially defined via macros. This may be a case where we want to use that more than the `visit_*` pieces perhaps. cc #711
Robbepop
changed the title
workspace: Remove Aug 19, 2022
wasmparser
: Remove Operator
typeOperator
type
Robbepop
changed the title
workspace: Remove
workspace: Remove Aug 19, 2022
Operator
typeOperator
type usage
Robbepop
changed the title
workspace: Remove
workspace: Remove Aug 19, 2022
Operator
type usagewasmparser::Operator
type usage
I'm going to actually go ahead and close this despite not being fully finished yet. With the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With #697 merged it is possible to remove the
Operator
type from thewasmparser
crate.The new
VisitOperator
trait allows to parse and validate Wasm without the need for matching on anOperator
. Instead respectivevisit
methods are invoked which avoid unnecessary unpredictable branches and is therefore the preferred and recommended API to use for high-performance Wasm parsing and validation.This issue tracks progress and discussion for removing the
Operator
type.cc @alexcrichton
ToDo
Operator
type in thewasmparser
crate.ConstExpr
validation: Remove the usage ofOperator
in const validation #737enum Operator
Operator
type in thewasmparser-dump
crate.Operator
inwasm-tools dump
#712Operator
type in thewasm-mutate
crate.Operator
type in thewasmprinter
crate.wasmprinter
tovisit_with_offset
#721VisitOperator
API.VisitOperator
API.The text was updated successfully, but these errors were encountered: