Test a wasm target in CI #1112
Merged
Test a wasm target in CI #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps them be a bit more cross-platform by not asserting the precise error message is the same across platforms.
Fuzzing doesn't compile for the wasm target and this is only required for a doc test which doesn't run on wasm anyway.
This relies on process support which wasm/WASI don't have, so always omit this subcommand.
This involves spawning processes which wasm can't do
The tests are currently tuned for 64-bit targets presumably due to the pattern of the RNG which differs based on the size of `usize`. This updates some limits and tests to pass on 32-bit, namely wasm, as well.
Keep the same limits for 64-bit targets but don't make the assertions platform-specific.
pchickey
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to help address a "root cause" of #1109 where this project is being used in the context of being compiled to wasm itself but we didn't actually test that on CI. This PR addresses the issue by adding a CI target that runs all the tests in CI. Some gotchas here were:
shrinkcommand is disabled unconditionally in the CLI since it requires spawning a processwasm-mutatetests had limits tweaked since the RNG behavior is different on 32-bit than on 64-bit (presumably because ofusize)wasm-composeare scrubbed more aggressively.