Remove union types #1180
Merged
Remove union types #1180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
commented
Aug 24, 2023
| // reason for this is that when visiting `var` the wasm-defined `(list | ||
| // visiting the `list<string>` case of the `foo` variant this ends up | ||
| // being different than the `list<string>` used by the `bar` variant. The | ||
| // reason for this is that when visiting `bar` the wasm-defined `(list |
Contributor
Author
There was a problem hiding this comment.
I think this preserves the intent of the comment, but I'll admit I didn't try to comprestand the whole thing very well.
alexcrichton
approved these changes
Aug 24, 2023
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Looks great to me, thanks!
Contributor
Author
|
Rebased on #1178 to fix rustfmt CI |
This was referenced Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all relevant references to "union".
Fixes #1179