Update *.wast parser with recently added directives
#1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parsing them is a bit wonky because it looks like this crate isn't architected the same way as the reference interpreter, but this so far otherwise seems to work. I've copied the upstream test added in WebAssembly/spec#1796 here for reference.
pchickey
approved these changes
Sep 10, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
* Update `*.wast` parser with recently added directives Parsing them is a bit wonky because it looks like this crate isn't architected the same way as the reference interpreter, but this so far otherwise seems to work. I've copied the upstream test added in WebAssembly/spec#1796 here for reference. * Fix compile of benches * Minor fixes
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing them is a bit wonky because it looks like this crate isn't architected the same way as the reference interpreter, but this so far otherwise seems to work. I've copied the upstream test added in WebAssembly/spec#1796 here for reference.