Remove the ability to turn off semicolons in WIT #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the final step in the transition to requiring semicolons in WIT. Long ago semicolons weren't required in WIT and now they are. This completes the last step of the transition after bytecodealliance#1269 by removing the `WIT_REQUIRE_SEMICOLONS` env var and making it a hardcoded requirement that they're present.
dicej
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final step in the transition to requiring semicolons in WIT. Long ago semicolons weren't required in WIT and now they are. This completes the last step of the transition after #1269 by removing the
WIT_REQUIRE_SEMICOLONSenv var and making it a hardcoded requirement that they're present.