Start removing custom translation in wasm-mutate #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `wasm_encoder::reencode` exists that's the better option to use for reencoding modules. This commit removes one of the major users of the equivalent `Translator` trait in `wasm_mutate` to start down the path of removing that trait entirely and instead relying on the support in `wasm_encoder`.
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Sep 17, 2024
Same as bytecodealliance#1794 except for another use of the `Translator` trait.
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Sep 17, 2024
Same as bytecodealliance#1794 except for another use of the `Translator` trait.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
Same as #1794 except for another use of the `Translator` trait.
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Sep 19, 2024
This commit fixes a small regression in reencoding from bytecodealliance#1794 where element segments subtly changed encoding by accident. This commit additionally ensures that there's a text format for all element encodings and updates printing to respect the same defaults. It should now be possible to represent all formats for element segments in the text format and have them round-trippable.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
This commit fixes a small regression in reencoding from #1794 where element segments subtly changed encoding by accident. This commit additionally ensures that there's a text format for all element encodings and updates printing to respect the same defaults. It should now be possible to represent all formats for element segments in the text format and have them round-trippable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
wasm_encoder::reencodeexists that's the better option to use for reencoding modules. This commit removes one of the major users of the equivalentTranslatortrait inwasm_mutateto start down the path of removing that trait entirely and instead relying on the support inwasm_encoder.