Remove custom translation framework from wasm-mutate #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use cargo features to reinterpret inputs to ensure that test cases can reproduce more easily when toggling features.
Let this fall through to the "unimplemented opcodes" section below instead of panicking.
Only used in a minor capacity, easy to transfer over.
* Add another hook in `Reencode` to process just elements * Change the internal slices to `Cow` instead of `&[T]` to be a bit more flexible in terms of ownership
Mostly just updating various bits and pieces here and there.
Now no-longer-needed.
Returns a first-class error instead of creating an invalid module.
Fall back on empty type info instead of panicking to get the error to crop up elsewhere for unsupported instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the final users of the
Translatortrait and migrates them towasm_encoder::reencode. Additionally when fuzzing this some minor issues have additionally been fixed in wasm-mutate.