Fix validation of catch/catch_all with try params
#710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an accidental regression from bytecodealliance#697 in the refactoring I added at the end where manual modification of `self.control` was replaced with `self.push_ctrl`. For the exceptions proposal specifically this is not valid since the `block_type` for the frame doesn't get the parameters pushed when the `catch` and `catch_all` instructions are encountered.
fitzgen
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an accidental regression from #697 in the refactoring
I added at the end where manual modification of
self.controlwasreplaced with
self.push_ctrl. For the exceptions proposal specificallythis is not valid since the
block_typefor the frame doesn't get theparameters pushed when the
catchandcatch_allinstructions areencountered.