Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to extract a world from a document #928

Merged

Conversation

alexcrichton
Copy link
Member

This pulls in bytecodealliance/wit-bindgen#494 as an "official" function to the wit-parser crate. I've written an analogue for that function in many locations so the hope is that all bindings generators can standardize on the necessary idioms by using this function. For example the Wasmtime bindings generator will want to update to use this as well.

This pulls in bytecodealliance/wit-bindgen#494 as an "official" function
to the `wit-parser` crate. I've written an analogue for that function in
many locations so the hope is that all bindings generators can
standardize on the necessary idioms by using this function. For example
the Wasmtime bindings generator will want to update to use this as well.
@alexcrichton
Copy link
Member Author

cc @sunfishcode

Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@alexcrichton alexcrichton enabled auto-merge (squash) February 13, 2023 16:19
@alexcrichton alexcrichton merged commit 902e289 into bytecodealliance:main Feb 13, 2023
@alexcrichton alexcrichton deleted the standard-select-world branch July 6, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants