Terminate the process if the callback exception handler throws another exception #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r exception, to ensure we don't let .NET exceptions fall through the native-to-managed transition. Fixes bytecodealliance#187
kpreisser
deleted the
prevent-exceptions-from-falling-through-callback
branch
kpreisser
added a commit
to kpreisser/wasmtime-dotnet
that referenced
this pull request
Dec 3, 2022
…ally throw an OOM due to the allocation that we need to catch. This is a follow-up to PR bytecodealliance#188.
kpreisser
added a commit
to kpreisser/wasmtime-dotnet
that referenced
this pull request
Dec 9, 2022
…to store the `Store` itself as context data, so that we can access it in function callbacks. This allows us to create a `funcref` value as `Function` using the associated `Store` instead of the `Caller`, so that it can be stored and then called outside of the callback. Fixes bytecodealliance#200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terminate the process with
Environment.FailFast()if the callback exception handler throws another exception, to ensure we don't let .NET exceptions bubble through the native-to-managed transition (which would be possible at least on Windows), as that causes undefined behavior withWasmtime.On Linux, the application will already crash consistently in such a case, so this makes the behavior on Windows consistent with the one on Linux.
Fixes #187
What do you think?
Thanks!