Fix Some C-API calls

[martindevans]

Fixed breakage due to changes introduced in bytecodealliance/wasmtime@e55fa3c

Obviously I can't run all the tests, due to the other changes mentioned here #315 (comment). Here's what I could run:

The WasiTests cover the changed code.

[jsturtevant]

Thanks! I've opened #317 which should help some. Maybe we need both?

[jsturtevant]

Looking alittle closer this, seem to only be a change in the wasmtime 0.22.0 versions. We will also need bytecodealliance/wasmtime@77405cc.

I am guessing we are missing other API changes between 0.19 and 0.22 which is why when pulling this into #317 didn't work

[martindevans]

Yeah this is only fixing the first of the two things you linked. We'll need another PR to fix bytecodealliance/wasmtime@77405cc.

At the end I guess we'll need to merge all 3 PRs together to test it it finally fixes all of the tests.

[jsturtevant]

At the end I guess we'll need to merge all 3 PRs together to test it it finally fixes all of the tests.

Yes, I would like to group the changes to get CI passing in order to merge. Without that I am not confident enough in the changes. I won't be able to get to bytecodealliance/wasmtime@77405cc today if you are interested in picking that up too. Thanks for the help!

[martindevans]

Unfortunately I don't think I'll have time today or tomorrow. It looks like a pretty complex set of changes!

[kpreisser]

Thanks for updating this!

It looks like the MarshalAs(UnmanagedType.I1) attribute is missing from the function delcaration, as without this, .NET would marshal the bool value as 4-byte BOOL, rather than as 1 byte value.

Otherwise, this looks good to me.

[jsturtevant]

@martindevans could you rebase? then we can get this in for 1.22 release

[martindevans]

@jsturtevant I'm on holiday at the moment. I'll be able to look at it on Sunday at the soonest.

If you want to take these changes and incorporate them yourself before then go ahead :)

[martindevans]

I just discovered GitHub itself has a button to automatically do the rebase, so I don't need access to my PC after all!

[jsturtevant]

@jsturtevant I'm on holiday at the moment. I'll be able to look at it on Sunday at the soonest.

no worries. Thanks and I hope you I didn't interrupt your personal time, that always takes precedent