Return anyhow::Error from host functions instead of Trap, redesig…

…n `Trap` (#5149)

* Return `anyhow::Error` from host functions instead of `Trap`

This commit refactors how errors are modeled when returned from host
functions and additionally refactors how custom errors work with `Trap`.
At a high level functions in Wasmtime that previously worked with
`Result<T, Trap>` now work with `Result<T>` instead where the error is
`anyhow::Error`. This includes functions such as:

* Host-defined functions in a `Linker<T>`
* `TypedFunc::call`
* Host-related callbacks like call hooks

Errors are now modeled primarily as `anyhow::Error` throughout Wasmtime.
This subsequently removes the need for `Trap` to have the ability to
represent all host-defined errors as it previously did. Consequently the
`From` implementations for any error into a `Trap` have been removed
here and the only embedder-defined way to create a `Trap` is to use
`Trap::new` with a custom string.

After this commit the distinction between a `Trap` and a host error is
the wasm backtrace that it contains. Previously all errors in host
functions would flow through a `Trap` and get a wasm backtrace attached
to them, but now this only happens if a `Trap` itself is created meaning
that arbitrary host-defined errors flowing from a host import to the
other side won't get backtraces attached. Some internals of Wasmtime
itself were updated or preserved to use `Trap::new` to capture a
backtrace where it seemed useful, such as when fuel runs out.

The main motivation for this commit is that it now enables hosts to
thread a concrete error type from a host function all the way through to
where a wasm function was invoked. Previously this could not be done
since the host error was wrapped in a `Trap` that didn't provide the
ability to get at the internals.

A consequence of this commit is that when a host error is returned that
isn't a `Trap` we'll capture a backtrace and then won't have a `Trap` to
attach it to. To avoid losing the contextual information this commit
uses the `Error::context` method to attach the backtrace as contextual
information to ensure that the backtrace is itself not lost.

This is a breaking change for likely all users of Wasmtime, but it's
hoped to be a relatively minor change to workaround. Most use cases can
likely change `-> Result<T, Trap>` to `-> Result<T>` and otherwise
explicit creation of a `Trap` is largely no longer necessary.

* Fix some doc links

* add some tests and make a backtrace type public (#55)

* Trap: avoid a trailing newline in the Display impl

which in turn ends up with three newlines between the end of the
backtrace and the `Caused by` in the anyhow Debug impl

* make BacktraceContext pub, and add tests showing downcasting behavior of anyhow::Error to traps or backtraces

* Remove now-unnecesary `Trap` downcasts in `Linker::module`

* Fix test output expectations

* Remove `Trap::i32_exit`

This commit removes special-handling in the `wasmtime::Trap` type for
the i32 exit code required by WASI. This is now instead modeled as a
specific `I32Exit` error type in the `wasmtime-wasi` crate which is
returned by the `proc_exit` hostcall. Embedders which previously tested
for i32 exits now downcast to the `I32Exit` value.

* Remove the `Trap::new` constructor

This commit removes the ability to create a trap with an arbitrary error
message. The purpose of this commit is to continue the prior trend of
leaning into the `anyhow::Error` type instead of trying to recreate it
with `Trap`. A subsequent simplification to `Trap` after this commit is
that `Trap` will simply be an `enum` of trap codes with no extra
information. This commit is doubly-motivated by the desire to always use
the new `BacktraceContext` type instead of sometimes using that and
sometimes using `Trap`.

Most of the changes here were around updating `Trap::new` calls to
`bail!` calls instead. Tests which assert particular error messages
additionally often needed to use the `:?` formatter instead of the `{}`
formatter because the prior formats the whole `anyhow::Error` and the
latter only formats the top-most error, which now contains the
backtrace.

* Merge `Trap` and `TrapCode`

With prior refactorings there's no more need for `Trap` to be opaque or
otherwise contain a backtrace. This commit parse down `Trap` to simply
an `enum` which was the old `TrapCode`. All various tests and such were
updated to handle this.

The main consequence of this commit is that all errors have a
`BacktraceContext` context attached to them. This unfortunately means
that the backtrace is printed first before the error message or trap
code, but given all the prior simplifications that seems worth it at
this time.

* Rename `BacktraceContext` to `WasmBacktrace`

This feels like a better name given how this has turned out, and
additionally this commit removes having both `WasmBacktrace` and
`BacktraceContext`.

* Soup up documentation for errors and traps

* Fix build of the C API

Co-authored-by: Pat Hickey <pat@moreproductive.org>

cranelift/codegen/src/ir/immediates.rs

@@ -473,7 +473,7 @@ impl FromStr for Offset32 {
 /// containing the bit pattern.
 ///
 /// We specifically avoid using a f32 here since some architectures may silently alter floats.
-/// See: https://github.com/bytecodealliance/wasmtime/pull/2251#discussion_r498508646
+/// See: <https://github.com/bytecodealliance/wasmtime/pull/2251#discussion_r498508646>
 ///
 /// The [PartialEq] and [Hash] implementations are over the underlying bit pattern, but
 /// [PartialOrd] respects IEEE754 semantics.
@@ -488,7 +488,7 @@ pub struct Ieee32(u32);
 /// containing the bit pattern.
 ///
 /// We specifically avoid using a f64 here since some architectures may silently alter floats.
-/// See: https://github.com/bytecodealliance/wasmtime/pull/2251#discussion_r498508646
+/// See: <https://github.com/bytecodealliance/wasmtime/pull/2251#discussion_r498508646>
 ///
 /// The [PartialEq] and [Hash] implementations are over the underlying bit pattern, but
 /// [PartialOrd] respects IEEE754 semantics.

crates/bench-api/src/lib.rs

@@ -136,14 +136,14 @@
 mod unsafe_send_sync;
 
 use crate::unsafe_send_sync::UnsafeSendSync;
-use anyhow::{anyhow, Context, Result};
+use anyhow::{Context, Result};
 use std::os::raw::{c_int, c_void};
 use std::slice;
 use std::{env, path::PathBuf};
 use target_lexicon::Triple;
 use wasmtime::{Config, Engine, Instance, Linker, Module, Store};
 use wasmtime_cli_flags::{CommonOptions, WasiModules};
-use wasmtime_wasi::{sync::WasiCtxBuilder, WasiCtx};
+use wasmtime_wasi::{sync::WasiCtxBuilder, I32Exit, WasiCtx};
 
 pub type ExitCode = c_int;
 pub const OK: ExitCode = 0;
@@ -539,14 +539,13 @@ impl BenchState {
  Err(trap) => {
  // Since _start will likely return by using the system `exit` call, we must
  // check the trap code to see if it actually represents a successful exit.
- match trap.i32_exit_status() {
- Some(0) => Ok(()),
- Some(n) => Err(anyhow!("_start exited with a non-zero code: {}", n)),
- None => Err(anyhow!(
- "executing the benchmark resulted in a trap: {}",
- trap
- )),
+ if let Some(exit) = trap.downcast_ref::<I32Exit>() {
+ if exit.0 == 0 {
+ return Ok(());
+ }
  }
+
+ Err(trap)
  }
  }
  }

crates/c-api/src/func.rs

@@ -3,6 +3,8 @@ use crate::{
  wasm_extern_t, wasm_functype_t, wasm_store_t, wasm_val_t, wasm_val_vec_t, wasmtime_error_t,
  wasmtime_extern_t, wasmtime_val_t, wasmtime_val_union, CStoreContext, CStoreContextMut,
 };
+use anyhow::{Error, Result};
+use std::any::Any;
 use std::ffi::c_void;
 use std::mem::{self, MaybeUninit};
 use std::panic::{self, AssertUnwindSafe};
@@ -67,7 +69,7 @@ unsafe fn create_function(
  let mut out_results: wasm_val_vec_t = vec![wasm_val_t::default(); results.len()].into();
  let out = func(&params, &mut out_results);
  if let Some(trap) = out {
- return Err(trap.trap.clone());
+ return Err(trap.error);
  }
 
  let out_results = out_results.as_slice();
@@ -152,24 +154,25 @@ pub unsafe extern "C" fn wasm_func_call(
  }
  ptr::null_mut()
  }
- Ok(Err(trap)) => match trap.downcast::<Trap>() {
- Ok(trap) => Box::into_raw(Box::new(wasm_trap_t::new(trap))),
- Err(err) => Box::into_raw(Box::new(wasm_trap_t::new(err.into()))),
- },
+ Ok(Err(err)) => Box::into_raw(Box::new(wasm_trap_t::new(err))),
  Err(panic) => {
- let trap = if let Some(msg) = panic.downcast_ref::<String>() {
- Trap::new(msg)
- } else if let Some(msg) = panic.downcast_ref::<&'static str>() {
- Trap::new(*msg)
- } else {
- Trap::new("rust panic happened")
- };
- let trap = Box::new(wasm_trap_t::new(trap));
+ let err = error_from_panic(panic);
+ let trap = Box::new(wasm_trap_t::new(err));
  Box::into_raw(trap)
  }
  }
 }
 
+fn error_from_panic(panic: Box<dyn Any + Send>) -> Error {
+ if let Some(msg) = panic.downcast_ref::<String>() {
+ Error::msg(msg.clone())
+ } else if let Some(msg) = panic.downcast_ref::<&'static str>() {
+ Error::msg(*msg)
+ } else {
+ Error::msg("rust panic happened")
+ }
+}
+
 #[no_mangle]
 pub unsafe extern "C" fn wasm_func_type(f: &wasm_func_t) -> Box<wasm_functype_t> {
  Box::new(wasm_functype_t::new(f.func().ty(f.ext.store.context())))
@@ -235,7 +238,7 @@ pub(crate) unsafe fn c_callback_to_rust_fn(
  callback: wasmtime_func_callback_t,
  data: *mut c_void,
  finalizer: Option<extern "C" fn(*mut std::ffi::c_void)>,
-) -> impl Fn(Caller<'_, crate::StoreData>, &[Val], &mut [Val]) -> Result<(), Trap> {
+) -> impl Fn(Caller<'_, crate::StoreData>, &[Val], &mut [Val]) -> Result<()> {
  let foreign = crate::ForeignData { data, finalizer };
  move |mut caller, params, results| {
  drop(&foreign); // move entire foreign into this closure
@@ -264,7 +267,7 @@ pub(crate) unsafe fn c_callback_to_rust_fn(
  out_results.len(),
  );
  if let Some(trap) = out {
- return Err(trap.trap);
+ return Err(trap.error);
  }
 
  // Translate the `wasmtime_val_t` results into the `results` space
@@ -299,14 +302,14 @@ pub(crate) unsafe fn c_unchecked_callback_to_rust_fn(
  callback: wasmtime_func_unchecked_callback_t,
  data: *mut c_void,
  finalizer: Option<extern "C" fn(*mut std::ffi::c_void)>,
-) -> impl Fn(Caller<'_, crate::StoreData>, &mut [ValRaw]) -> Result<(), Trap> {
+) -> impl Fn(Caller<'_, crate::StoreData>, &mut [ValRaw]) -> Result<()> {
  let foreign = crate::ForeignData { data, finalizer };
  move |caller, values| {
  drop(&foreign); // move entire foreign into this closure
  let mut caller = wasmtime_caller_t { caller };
  match callback(foreign.data, &mut caller, values.as_mut_ptr(), values.len()) {
  None => Ok(()),
- Some(trap) => Err(trap.trap),
+ Some(trap) => Err(trap.error),
  }
  }
 }
@@ -348,22 +351,17 @@ pub unsafe extern "C" fn wasmtime_func_call(
  store.data_mut().wasm_val_storage = params;
  None
  }
- Ok(Err(trap)) => match trap.downcast::<Trap>() {
- Ok(trap) => {
+ Ok(Err(trap)) => {
+ if trap.is::<Trap>() {
  *trap_ret = Box::into_raw(Box::new(wasm_trap_t::new(trap)));
  None
+ } else {
+ Some(Box::new(wasmtime_error_t::from(trap)))
  }
- Err(err) => Some(Box::new(wasmtime_error_t::from(err))),
- },
+ }
  Err(panic) => {
- let trap = if let Some(msg) = panic.downcast_ref::<String>() {
- Trap::new(msg)
- } else if let Some(msg) = panic.downcast_ref::<&'static str>() {
- Trap::new(*msg)
- } else {
- Trap::new("rust panic happened")
- };
- *trap_ret = Box::into_raw(Box::new(wasm_trap_t::new(trap)));
+ let err = error_from_panic(panic);
+ *trap_ret = Box::into_raw(Box::new(wasm_trap_t::new(err)));
  None
  }
  }

crates/c-api/src/instance.rs

@@ -41,7 +41,7 @@ pub unsafe extern "C" fn wasm_instance_new(
  ))),
  Err(e) => {
  if let Some(ptr) = result {
- *ptr = Box::into_raw(Box::new(wasm_trap_t::new(e.into())));
+ *ptr = Box::into_raw(Box::new(wasm_trap_t::new(e)));
  }
  None
  }
@@ -100,7 +100,7 @@ pub(crate) fn handle_instantiate(
  }
  Err(e) => match e.downcast::<Trap>() {
  Ok(trap) => {
- *trap_ptr = Box::into_raw(Box::new(wasm_trap_t::new(trap)));
+ *trap_ptr = Box::into_raw(Box::new(wasm_trap_t::new(trap.into())));
  None
  }
  Err(e) => Some(Box::new(e.into())),