Remove module-name-override as per review comment.

crates/wasmtime/src/module.rs

@@ -189,25 +189,10 @@ impl Module {
     #[cfg(compiler)]
     #[cfg_attr(nightlydoc, doc(cfg(feature = "cranelift")))] // see build.rs
     pub fn new(engine: &Engine, bytes: impl AsRef<[u8]>) -> Result<Module> {
-        Self::new_impl(engine, bytes, None)
-    }
-
-    /// Creates a new WebAssembly `Module` from the given in-memory `binary`
-    /// data. The provided `name` will be used in traps/backtrace details.
-    ///
-    /// See [`Module::new`] for other details.
-    #[cfg(compiler)]
-    #[cfg_attr(nightlydoc, doc(cfg(feature = "cranelift")))] // see build.rs
-    pub fn new_with_name(engine: &Engine, bytes: impl AsRef<[u8]>, name: &str) -> Result<Module> {
-        Self::new_impl(engine, bytes, Some(name.to_string()))
-    }
-
-    #[cfg(compiler)]
-    fn new_impl(engine: &Engine, bytes: impl AsRef<[u8]>, name: Option<String>) -> Result<Module> {
         let bytes = bytes.as_ref();
         #[cfg(feature = "wat")]
         let bytes = wat::parse_bytes(bytes)?;
-        Self::from_binary_with_name(engine, &bytes, name)
+        Self::from_binary(engine, &bytes)
     }
 
     /// Creates a new WebAssembly `Module` from the contents of the given
@@ -294,15 +279,6 @@ impl Module {
     #[cfg(compiler)]
     #[cfg_attr(nightlydoc, doc(cfg(feature = "cranelift")))] // see build.rs
     pub fn from_binary(engine: &Engine, binary: &[u8]) -> Result<Module> {
-        Self::from_binary_with_name(engine, binary, None)
-    }
-
-    #[cfg(compiler)]
-    fn from_binary_with_name(
-        engine: &Engine,
-        binary: &[u8],
-        name: Option<String>,
-    ) -> Result<Module> {
         // Check to see that the config's target matches the host
         let target = engine.compiler().triple();
         if *target != target_lexicon::Triple::host() {
@@ -363,7 +339,7 @@ impl Module {
             )
         })?;
 
-        Self::from_parts(engine, modules, main_module, Arc::new(types), &[], name)
+        Self::from_parts(engine, modules, main_module, Arc::new(types), &[])
     }
 
     /// Converts an input binary-encoded WebAssembly module to compilation
@@ -518,7 +494,6 @@ impl Module {
         main_module: usize,
         types: Arc<TypeTables>,
         module_upvars: &[serialization::SerializedModuleUpvar],
-        name: Option<String>,
     ) -> Result<Self> {
         // Validate the module can be used with the current allocator
         engine.allocator().validate(modules[main_module].module())?;
@@ -531,14 +506,7 @@ impl Module {
                 .flat_map(|m| m.trampolines().map(|(idx, f, _)| (idx, f))),
         ));
 
-        let mut module = modules.remove(main_module);
-        if let Some(name) = name {
-            Arc::get_mut(&mut module)
-                .expect("should be only Arc ref to CompiledModule")
-                .module_mut()
-                .expect("should be only Arc ref to Module")
-                .name = Some(name);
-        }
+        let module = modules.remove(main_module);
 
         let shared_signatures = SharedSignatures::Table(signatures.as_module_map().clone());
         let runtime_info = Arc::new(ModuleRuntimeInfo::new(&module, shared_signatures));

crates/wasmtime/src/module/serialization.rs

@@ -288,7 +288,7 @@ impl<'a> SerializedModule<'a> {
             )
         })?;
 
-        Module::from_parts(engine, modules, main_module, Arc::new(types), &upvars, None)
+        Module::from_parts(engine, modules, main_module, Arc::new(types), &upvars)
     }
 
     pub fn into_parts(

tests/all/name.rs

@@ -27,8 +27,5 @@ fn test_module_name() -> anyhow::Result<()> {
     let module = Module::new(&engine, wat)?;
     assert_eq!(module.name(), Some("from_name_section"));
 
-    let module = Module::new_with_name(&engine, wat, "override")?;
-    assert_eq!(module.name(), Some("override"));
-
     Ok(())
 }