Skip to content

Commit

Permalink
update WASI submodule (#3025)
Browse files Browse the repository at this point in the history
* wasi-common: update wasi submodule

This updates the WASI submodule, pulling in changes to the witx crate,
now that there is a 0.9.1 version including some bug fixes. See
WebAssembly/WASI#434 for more information.

* wiggle: update witx dependencies

* publish: verify and vendor witx-cli

* adjust root workspace members

This commit removes some items from the root manifest's workspace
members array, and adds `witx-cli` to the root `workspace.exclude`
array.

The motivation for this stems from a cargo bug described in
rust-lang/cargo#6745: `workspace.exclude` does not work if it is nested
under a `workspace.members` path.

See WebAssembly/WASI#438 for the underlying change to the WASI submodule
which reorganized the `witx-cli` crate, and WebAssembly/WASI#398 for the
original PR introducing `witx-cli`.

See [this
comment](#3025 (comment))
for more details about the compilation errors, and failed alternative
approaches that necessitated this change.

N.B. This is not a functional change, these crates are still implicitly
workspace members as transitive dependencies, but this will allow us to
side-step the aforementioned cargo bug.

Co-Authored-By: Alex Crichton <alex@alexcrichton.com>

Co-authored-by: Alex Crichton <alex@alexcrichton.com>
  • Loading branch information
katelyn martin and alexcrichton authored Jun 24, 2021
1 parent 652f21e commit ab53612
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 25 deletions.
17 changes: 4 additions & 13 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 1 addition & 7 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -73,19 +73,13 @@ members = [
"cranelift",
"crates/bench-api",
"crates/c-api",
"crates/fuzzing",
"crates/misc/run-examples",
"crates/wiggle",
"crates/wiggle/generate",
"crates/wiggle/macro",
"crates/wasi-common",
"crates/wasi-common/cap-std-sync",
"crates/wasi-common/tokio",
"examples/fib-debug/wasm",
"examples/wasi/wasm",
"examples/tokio/wasm",
"fuzz",
]
exclude = ['crates/wasi-common/WASI/tools/witx-cli']

[features]
default = ["jitdump", "wasmtime/wat", "wasmtime/parallel-compilation", "wasi-nn"]
Expand Down
2 changes: 1 addition & 1 deletion crates/wasi-common/WASI
Submodule WASI updated 64 files
+15 −5 .github/workflows/main.yml
+1 −1 README.md
+1 −1 docs/Proposals.md
+0 −377 meetings/2019/WASI-05-02.md
+0 −291 meetings/2019/WASI-05-16.md
+0 −116 meetings/2019/WASI-05-30.md
+0 −241 meetings/2019/WASI-06-27.md
+0 −262 meetings/2019/WASI-07-18.md
+0 −121 meetings/2019/WASI-08-15.md
+0 −64 meetings/2019/WASI-08-30.md
+0 −92 meetings/2019/WASI-09-12.md
+0 −60 meetings/2019/WASI-09-26.md
+0 −116 meetings/2019/WASI-10-15.md
+0 −171 meetings/2019/WASI-10-24.md
+0 −102 meetings/2019/WASI-11-07.md
+0 −63 meetings/2019/WASI-11-21.md
+0 −124 meetings/2019/WASI-12-05.md
+0 −44 meetings/2019/WASI-12-19.md
+ meetings/2019/What HTTP Needs from WebAssembly.pdf
+0 −123 meetings/2020/WASI-01-16.md
+0 −92 meetings/2020/WASI-02-27.md
+0 −85 meetings/2020/WASI-03-12.md
+0 −126 meetings/2020/WASI-03-26.md
+0 −83 meetings/2020/WASI-04-09.md
+0 −89 meetings/2020/WASI-05-07.md
+0 −99 meetings/2020/WASI-05-21.md
+0 −43 meetings/2020/WASI-06-04.md
+0 −41 meetings/2020/WASI-07-02.md
+0 −41 meetings/2020/WASI-07-16.md
+0 −36 meetings/2020/WASI-07-30.md
+0 −42 meetings/2020/WASI-08-27.md
+0 −33 meetings/2020/WASI-09-10.md
+0 −30 meetings/2020/WASI-09-24.md
+0 −42 meetings/2020/WASI-10-08.md
+0 −211 meetings/2020/WASI-10-22.md
+0 −153 meetings/2020/WASI-11-19.md
+0 −130 meetings/2020/WASI-12-03.md
+0 −75 meetings/2021/WASI-01-14.md
+0 −206 meetings/2021/WASI-01-28.md
+0 −118 meetings/2021/WASI-02-11.md
+0 −33 meetings/2021/WASI-02-25.md
+0 −50 meetings/README.md
+18 −8 phases/ephemeral/docs.md
+12 −2 phases/ephemeral/witx/typenames.witx
+2 −1 phases/ephemeral/witx/wasi_ephemeral_args.witx
+1 −0 phases/ephemeral/witx/wasi_ephemeral_environ.witx
+6 −3 phases/ephemeral/witx/wasi_ephemeral_proc.witx
+3 −1 phases/old/snapshot_0/docs.md
+3 −1 phases/old/snapshot_0/witx/wasi_unstable.witx
+3 −1 phases/snapshot/docs.md
+3 −1 phases/snapshot/witx/wasi_snapshot_preview1.witx
+ test/minimal-command.wasm
+8 −0 test/sources/generate-wasm.sh
+3 −0 test/sources/wat/minimal-command.wat
+17 −0 tools/repo_docs.sh
+1 −0 tools/test-harness/exit_status_zero
+17 −0 tools/test-harness/run.sh
+90 −0 tools/test-harness/testcase.sh
+25 −0 tools/witx-cli/Cargo.toml
+110 −17 tools/witx-cli/src/main.rs
+2 −5 tools/witx/Cargo.toml
+4 −4 tools/witx/src/io.rs
+32 −0 tools/witx/src/toplevel.rs
+0 −99 tools/witx/tests/wasi-docs.rs
2 changes: 1 addition & 1 deletion crates/wiggle/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ include = ["src/**/*", "README.md", "LICENSE"]

[dependencies]
thiserror = "1"
witx = { path = "../wasi-common/WASI/tools/witx", version = "0.9.0", optional = true }
witx = { path = "../wasi-common/WASI/tools/witx", version = "0.9.1", optional = true }
wiggle-macro = { path = "macro", version = "0.28.0" }
tracing = "0.1.15"
bitflags = "1.2"
Expand Down
2 changes: 1 addition & 1 deletion crates/wiggle/generate/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ include = ["src/**/*", "README.md", "LICENSE"]
[lib]

[dependencies]
witx = { version = "0.9.0", path = "../../wasi-common/WASI/tools/witx" }
witx = { version = "0.9.1", path = "../../wasi-common/WASI/tools/witx" }
quote = "1.0"
proc-macro2 = "1.0"
heck = "0.3"
Expand Down
2 changes: 1 addition & 1 deletion crates/wiggle/macro/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ doctest = false

[dependencies]
wiggle-generate = { path = "../generate", version = "0.28.0" }
witx = { version = "0.9.0", path = "../../wasi-common/WASI/tools/witx" }
witx = { version = "0.9.1", path = "../../wasi-common/WASI/tools/witx" }
quote = "1.0"
syn = { version = "1.0", features = ["full"] }
proc-macro2 = "1.0"
Expand Down
2 changes: 1 addition & 1 deletion scripts/publish.rs
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ fn read_crate(manifest: &Path) -> Crate {
} else {
version.clone()
};
if ["witx", "wasi-crypto"].contains(&&name[..]) {
if ["witx", "witx-cli", "wasi-crypto"].contains(&&name[..]) {
publish = false;
}
Crate {
Expand Down

0 comments on commit ab53612

Please sign in to comment.