Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIMD testsuite tests failing with speed optimization. #1186

Closed
peterhuene opened this issue Feb 26, 2020 · 1 comment · Fixed by #1637
Closed

SIMD testsuite tests failing with speed optimization. #1186

peterhuene opened this issue Feb 26, 2020 · 1 comment · Fixed by #1637
Assignees
@abrown
Labels
bug Incorrect behavior in the current implementation that needs fixing cranelift Issues related to the Cranelift code generator

Comments

@peterhuene
Copy link
Member

See #988 which is enabling speed optimizations by default in the Rust and C APIs for Wasmtime.

This caused failures in the SIMD testsuite tests as noted in that PR.

To reproduce, comment out the FIXME lines in tests/wast_testsuites.rs that are disabling optimizations when testing with SIMD enabled.
@alexcrichton alexcrichton transferred this issue from bytecodealliance/cranelift Feb 28, 2020
@alexcrichton alexcrichton added bug Incorrect behavior in the current implementation that needs fixing cranelift Issues related to the Cranelift code generator labels Feb 28, 2020
@bjorn3
Copy link
Contributor

bjorn3 commented Feb 29, 2020

The assignment got lost when transfering this issue to wasmtime.

abrown added a commit to abrown/wasmtime that referenced this issue Apr 30, 2020
@abrown
Use complex load-extend instructions in optimize_complex_addresses; f…
c3d8ded 
…ixes bytecodealliance#1186
@abrown abrown mentioned this issue Apr 30, 2020
Merged
abrown added a commit to abrown/wasmtime that referenced this issue Apr 30, 2020
@abrown
Use complex load-extend instructions in optimize_complex_addresses; f…
1537b26 
…ixes bytecodealliance#1186
@abrown abrown linked a pull request Apr 30, 2020 that will close this issue
Enable optimizations for SIMD spec tests #1637
Merged
abrown added a commit to abrown/wasmtime that referenced this issue Apr 30, 2020
@abrown
Use complex load-extend instructions in optimize_complex_addresses; f…
39aa357 
…ixes bytecodealliance#1186
abrown added a commit that referenced this issue Apr 30, 2020
@abrown
Use complex load-extend instructions in optimize_complex_addresses; f…
49622bd 
…ixes #1186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abrown abrown

Labels
bug Incorrect behavior in the current implementation that needs fixing cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable optimizations for SIMD spec tests abrown/wasmtime
4 participants
@alexcrichton @peterhuene @abrown @bjorn3