Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port unwind tests to new x64 backend #2415

Closed
cfallin opened this issue Nov 13, 2020 · 1 comment
Closed

Port unwind tests to new x64 backend #2415

cfallin opened this issue Nov 13, 2020 · 1 comment

Comments

@cfallin
Copy link
Member

cfallin commented Nov 13, 2020

In #2411, we discovered that unwind tests for the x86 backend are running even when the new x64 backend is enabled, resulting in test failures (due to the mismatch of implementation internals). In that PR, we disabled the old tests on the new configuration; but before we remove the old backend entirely, we need to preserve the test coverage by porting the tests over. This should largely be mechanical, with just some updates to the expected unwind info if the prologues/epilogues differ slightly.

@alexcrichton
Copy link
Member

I think all unwinding bits and pieces for the new backend are now in place, so I figure this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants