Don't run old x86 backend-specific tests with new x64 backend. #2411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the test failures tracked by bytecodealliance#2079 are in unwind tests that are specific to the old x86 backend: namely, these tests invoke the unwind implementation that is paired with the old backend, rather than generic over all backends. It thus doesn't make sense to try to run these tests with the new backend. (The new backend's unwind code should have analogous tests written/ported over eventually.) It seems that we were actually building *both* x86 backends when the `x64` feature was enabled, except that the old x86 backend would never be instantiated by the usual ISA-lookup logic because a `x86-64` target triple unconditionally resolves to the new one. This PR resolves both of the issues by tweaking the feature-config directives to exclude the `x86` backend when `x64` is enabled.
github-actions
bot
added
the
cranelift
Would it make sense to file an issue for this so it doesn't get lost? |
abrown
approved these changes
Nov 13, 2020
|
Indeed (to both), we will need to port the tests over before the old backend goes away! Created #2415 for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the test failures tracked by #2079 are in unwind tests that are
specific to the old x86 backend: namely, these tests invoke the unwind
implementation that is paired with the old backend, rather than generic
over all backends. It thus doesn't make sense to try to run these tests
with the new backend. (The new backend's unwind code should have
analogous tests written/ported over eventually.)
It seems that we were actually building both x86 backends when the
x64feature was enabled, except that the old x86 backend would neverbe instantiated by the usual ISA-lookup logic because a
x86-64targettriple unconditionally resolves to the new one.
This PR resolves both of the issues by tweaking the feature-config
directives to exclude the
x86backend whenx64is enabled.