Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cranelift: support vector instructions without optional ISA extensions #3810

Closed
cfallin opened this issue Feb 16, 2022 · 2 comments · Fixed by #4231
Closed

Cranelift: support vector instructions without optional ISA extensions #3810

cfallin opened this issue Feb 16, 2022 · 2 comments · Fixed by #4231
Labels
cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator

Comments

@cfallin
Copy link
Member

cfallin commented Feb 16, 2022

In #3809, a new extension to our fuzzing found that some of our Wasm-SIMD support requires nominally optional ISA features, at least on x86-64.

I think we should try to have fallbacks such that we can support all relevant features on any machine that supports the base ISA. On x86-64, this means just SSE2. Or if this is very difficult for some reason, we should document why and then possibly consider raising our minimum required ISA version.
@alexcrichton alexcrichton mentioned this issue Feb 16, 2022
Closed
@cfallin cfallin mentioned this issue Feb 23, 2022
Merged
@alexcrichton alexcrichton added wasmtime Issues about wasmtime that don't fall into another label cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator and removed wasmtime Issues about wasmtime that don't fall into another label labels Mar 23, 2022
@cfallin cfallin mentioned this issue May 4, 2022
Closed
This was referenced Jun 4, 2022
Closed
Merged
@cfallin cfallin reopened this Jun 8, 2022
@cfallin
Copy link
Member Author

cfallin commented Jun 8, 2022

Reopened; GH mis-parsed "once we fix #3810" as "fix #3810" in #4231's commit.

@cfallin cfallin mentioned this issue May 18, 2023
Merged
@alexcrichton
Copy link
Member

I believe that this is now done, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cranelift-native flags detection: fix flags on SSE2-only systems. cfallin/wasmtime
2 participants
@alexcrichton @cfallin