Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wasmtime: Config order of method calls should not matter #4189

Closed
PureWhiteWu opened this issue May 26, 2022 · 0 comments · Fixed by #4252
Closed

Wasmtime: Config order of method calls should not matter #4189

PureWhiteWu opened this issue May 26, 2022 · 0 comments · Fixed by #4252

Comments

@PureWhiteWu
Copy link
Contributor

The order of method calls matters now, this should be fixed.

For more details, see #4188.
@PureWhiteWu PureWhiteWu mentioned this issue May 26, 2022
Closed
PureWhiteWu added a commit to PureWhiteWu/wasmtime that referenced this issue Jun 9, 2022
@PureWhiteWu
fix(wasmtime):Config methods should be idempotent
f89bc60 
This commit refactored `Config` to use a seperate `CompilerConfig` field instead
of operating on `CompilerBuilder` directly to make all its methods idempotent.

Fixes bytecodealliance#4189
@PureWhiteWu PureWhiteWu mentioned this issue Jun 9, 2022
Merged
PureWhiteWu added a commit to PureWhiteWu/wasmtime that referenced this issue Jun 9, 2022
@PureWhiteWu
fix(wasmtime):Config methods should be idempotent
7db2afb 
This commit refactored `Config` to use a seperate `CompilerConfig` field instead
of operating on `CompilerBuilder` directly to make all its methods idempotent.

Fixes bytecodealliance#4189
PureWhiteWu added a commit to PureWhiteWu/wasmtime that referenced this issue Jun 9, 2022
@PureWhiteWu
fix(wasmtime):Config methods should be idempotent
4227ed2 
This commit refactored `Config` to use a seperate `CompilerConfig` field instead
of operating on `CompilerBuilder` directly to make all its methods idempotent.

Fixes bytecodealliance#4189
PureWhiteWu added a commit to PureWhiteWu/wasmtime that referenced this issue Jun 9, 2022
@PureWhiteWu
fix(wasmtime):Config methods should be idempotent
e212d86 
This commit refactored `Config` to use a seperate `CompilerConfig` field instead
of operating on `CompilerBuilder` directly to make all its methods idempotent.

Fixes bytecodealliance#4189
PureWhiteWu added a commit to PureWhiteWu/wasmtime that referenced this issue Jun 9, 2022
@PureWhiteWu
fix(wasmtime):Config methods should be idempotent
3f57e76 
This commit refactored `Config` to use a seperate `CompilerConfig` field instead
of operating on `CompilerBuilder` directly to make all its methods idempotent.

Fixes bytecodealliance#4189
PureWhiteWu added a commit to PureWhiteWu/wasmtime that referenced this issue Jun 9, 2022
@PureWhiteWu
fix(wasmtime):Config methods should be idempotent
9ea619a 
This commit refactored `Config` to use a seperate `CompilerConfig` field instead
of operating on `CompilerBuilder` directly to make all its methods idempotent.

Fixes bytecodealliance#4189
PureWhiteWu added a commit to PureWhiteWu/wasmtime that referenced this issue Jun 9, 2022
@PureWhiteWu
fix(wasmtime):Config methods should be idempotent
fb584d1 
This commit refactored `Config` to use a seperate `CompilerConfig` field instead
of operating on `CompilerBuilder` directly to make all its methods idempotent.

Fixes bytecodealliance#4189
PureWhiteWu added a commit to PureWhiteWu/wasmtime that referenced this issue Jun 9, 2022
@PureWhiteWu
fix(wasmtime):Config methods should be idempotent
9046577 
This commit refactored `Config` to use a seperate `CompilerConfig` field instead
of operating on `CompilerBuilder` directly to make all its methods idempotent.

Fixes bytecodealliance#4189
PureWhiteWu added a commit to PureWhiteWu/wasmtime that referenced this issue Jun 9, 2022
@PureWhiteWu
fix(wasmtime):Config methods should be idempotent
5964000 
This commit refactored `Config` to use a seperate `CompilerConfig` field instead
of operating on `CompilerBuilder` directly to make all its methods idempotent.

Fixes bytecodealliance#4189
PureWhiteWu added a commit to PureWhiteWu/wasmtime that referenced this issue Jun 9, 2022
@PureWhiteWu
fix(wasmtime):Config methods should be idempotent
7d83e3c 
This commit refactored `Config` to use a seperate `CompilerConfig` field instead
of operating on `CompilerBuilder` directly to make all its methods idempotent.

Fixes bytecodealliance#4189
PureWhiteWu added a commit to PureWhiteWu/wasmtime that referenced this issue Jun 9, 2022
@PureWhiteWu
fix(wasmtime):Config methods should be idempotent
0ba39e2 
This commit refactored `Config` to use a seperate `CompilerConfig` field instead
of operating on `CompilerBuilder` directly to make all its methods idempotent.

Fixes bytecodealliance#4189
PureWhiteWu added a commit to PureWhiteWu/wasmtime that referenced this issue Jun 10, 2022
@PureWhiteWu
fix(wasmtime):Config methods should be idempotent
a7b00f7 
This commit refactored `Config` to use a seperate `CompilerConfig` field instead
of operating on `CompilerBuilder` directly to make all its methods idempotent.

Fixes bytecodealliance#4189
alexcrichton pushed a commit that referenced this issue Jun 13, 2022
@PureWhiteWu
fix(wasmtime):Config methods should be idempotent (#4252)
258dc9d 
This commit refactored `Config` to use a seperate `CompilerConfig` field instead
of operating on `CompilerBuilder` directly to make all its methods idempotent.

Fixes #4189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(wasmtime):Config methods should be idempotent PureWhiteWu/wasmtime
1 participant
@PureWhiteWu