Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide release details in GitHub Releases #7068

Closed
brettcannon opened this issue Sep 20, 2023 · 7 comments · Fixed by #7405
Closed

Provide release details in GitHub Releases #7068

brettcannon opened this issue Sep 20, 2023 · 7 comments · Fixed by #7405

Comments

@brettcannon
Copy link
Contributor

When you look at https://github.com/bytecodealliance/wasmtime/releases/tag/v13.0.0 there's no information about what is in the release (and subscribing to GitHub release notifications means releases are, at least for me, the primary way to find out about new releases). You have to navigate to https://github.com/bytecodealliance/wasmtime/blob/main/RELEASES.md#1300 in order to find out what's contained in the release.

Any way to either inline the release notes into the GitHub release or at least provide a link to the document?

@alexcrichton
Copy link
Member

I agree! The best thing to do here would probably be to copy the release notes that you've linked to the release itself, ideally automatically. Fiddling with the release process is pretty difficult though since it's difficult to test, and I suspect this'll require some well-crafted shell commands and such to get right which I'm not myself 100% sure of.

@rockwotj
Copy link
Contributor

Maybe in the meantime having a single link to release file is a good middle ground?

@sandstrom
Copy link

I agree, it's somewhat hard to follow today. For example, this screenshot shows two releases, with no changes in either of them. Doesn't make any sense to me.

image

Github has built-in support for auto-generating release notes, based on the labels of all associated PRs.

It's a pretty easy way of getting good release notes with simple grouping (features, internal, bug fixes, cleanups, documentation, etc).

https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes

Looks like this: https://github.com/github/issue-metrics/releases

@bjorn3
Copy link
Contributor

bjorn3 commented Oct 26, 2023

Rust has a bot which copies the release notes from RELEASES.md into github releases I believe. Maybe the same could be done for Wasmtime?

@alexcrichton
Copy link
Member

You wouldn't happen to have a link on-hand to how this is integrated in to rust-lang/rust, would you? I'm not sure how to configure this all myself.

@bjorn3
Copy link
Contributor

bjorn3 commented Oct 27, 2023

Seems to be part of triagebot: https://github.com/rust-lang/triagebot/tree/master/src/changelogs Should be possible to port it to github actions though.

alexcrichton added a commit to alexcrichton/wasmtime that referenced this issue Oct 30, 2023
This commit is an attempt to tackle bytecodealliance#7068 by configuring the release
notes in Github Releases with the handwritten release notes from
`RELEASES.md`. The basic idea here is to split the markdown file on
`-----` delimiters and then find the one which matches the version being
released. Once one is found the `body` field of the API call to create
the release is configured.

This is unfortunately quite difficult to test, so I haven't actually
tested it. I'm hoping this won't at least halt the release so we can see
how it goes for the next one and fix any issues that arise.
alexcrichton added a commit to alexcrichton/wasmtime that referenced this issue Oct 30, 2023
This commit is an attempt to tackle bytecodealliance#7068 by configuring the release
notes in Github Releases with the handwritten release notes from
`RELEASES.md`. The basic idea here is to split the markdown file on
`-----` delimiters and then find the one which matches the version being
released. Once one is found the `body` field of the API call to create
the release is configured.
@alexcrichton
Copy link
Member

Ok I think this will be fixed by #7405

github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2023
* Attempt to automatically configure release notes

This commit is an attempt to tackle #7068 by configuring the release
notes in Github Releases with the handwritten release notes from
`RELEASES.md`. The basic idea here is to split the markdown file on
`-----` delimiters and then find the one which matches the version being
released. Once one is found the `body` field of the API call to create
the release is configured.

* Update .github/actions/github-release/main.js

Co-authored-by: Andrew Brown <andrew.brown@intel.com>

---------

Co-authored-by: Andrew Brown <andrew.brown@intel.com>
alexcrichton added a commit to alexcrichton/wasmtime that referenced this issue Oct 31, 2023
* Attempt to automatically configure release notes

This commit is an attempt to tackle bytecodealliance#7068 by configuring the release
notes in Github Releases with the handwritten release notes from
`RELEASES.md`. The basic idea here is to split the markdown file on
`-----` delimiters and then find the one which matches the version being
released. Once one is found the `body` field of the API call to create
the release is configured.

* Update .github/actions/github-release/main.js

Co-authored-by: Andrew Brown <andrew.brown@intel.com>

---------

Co-authored-by: Andrew Brown <andrew.brown@intel.com>
alexcrichton added a commit that referenced this issue Oct 31, 2023
* Attempt to automatically configure release notes

This commit is an attempt to tackle #7068 by configuring the release
notes in Github Releases with the handwritten release notes from
`RELEASES.md`. The basic idea here is to split the markdown file on
`-----` delimiters and then find the one which matches the version being
released. Once one is found the `body` field of the API call to create
the release is configured.

* Update .github/actions/github-release/main.js



---------

Co-authored-by: Andrew Brown <andrew.brown@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@brettcannon @alexcrichton @sandstrom @rockwotj @bjorn3 and others