-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cranelift optimizations aren't enabled by default for the API. #981
Comments
Agreed! I don't think we necessarily want the CLI to match everything about the API, for example I think it's probably the way we want it to have the CLI have an on-by-default cache but the API has an off-by-default cache. For something like this though I think it's best to match the two. |
Totally. Off by default cache makes sense to me since the use cases for embedding are so varied. With respect to optimization, I would imagine that embedders will want optimized codegen almost all of the time and so it makes sense to have it on by default for such an important performance feature. |
This commit changes the default opt-level for a new `Config` to `speed`. Fixes bytecodealliance#981.
This commit changes the default opt-level for a new `Config` to `speed`. Fixes bytecodealliance#981.
This commit changes the default opt-level for a new `Config` to `speed`. Fixes bytecodealliance#981.
We've recently turned optimizations on by default in the CLI.
I think we should probably enable optimizations by default for both the Rust and C APIs.
I propose we enable the cranelift optimization level to match the CLI for
Engine::default()
(thusConfig::new
sets the optimization level).The text was updated successfully, but these errors were encountered: