[29.0.0] Fix dropping cached stack with Store::into_data
#10014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0009) This commit fixes a regression from bytecodealliance#9604 where using `Store::into_data` wouldn't properly drop a cached stack in a store like a `Drop` destructor. The fix here is to add the `flush_fiber_stack` method into the `into_data` here as well.
pchickey
approved these changes
Jan 14, 2025
alexcrichton
merged commit c72e60f
into
bytecodealliance:release-29.0.0
136 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10009 for this release branch before it's released this weekend.