Fix missing libcalls with simd float rounding #10699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes some more fallout found on oss-fuzz about the x64 generating rounding builtins when it shouldn't be. This situation is caused by simd float rounding instructions which the x64 backend lowers to libcall-per-element and now needs to move that logic to the frontend instead.
Member
Author
|
cc @sunfishcode |
dicej
reviewed
Apr 30, 2025
Contributor
dicej
left a comment
dicej
left a comment
There was a problem hiding this comment.
I don't have enough Cranelift context yet to evaluate this properly, so I'll let Dan review it before approving, but LGTM.
Member
Author
|
@fitzgen would you be able to take a look at this perhaps? |
fitzgen
approved these changes
May 5, 2025
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
May 6, 2025
This commit is similar to bytecodealliance#10699, another instance of a libcall popping up late in the x64 backend. Fuzzing found this issue and to help verify this is the last one I've run the whole `*.wast` test suite with the x86_64 baseline (no target features) and saw the panic before this PR and no more panics after.
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 6, 2025
This commit is similar to #10699, another instance of a libcall popping up late in the x64 backend. Fuzzing found this issue and to help verify this is the last one I've run the whole `*.wast` test suite with the x86_64 baseline (no target features) and saw the panic before this PR and no more panics after.
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
May 7, 2025
This commit fixes some more fallout found on oss-fuzz about the x64 generating rounding builtins when it shouldn't be. This situation is caused by simd float rounding instructions which the x64 backend lowers to libcall-per-element and now needs to move that logic to the frontend instead.
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
May 7, 2025
This commit is similar to bytecodealliance#10699, another instance of a libcall popping up late in the x64 backend. Fuzzing found this issue and to help verify this is the last one I've run the whole `*.wast` test suite with the x86_64 baseline (no target features) and saw the panic before this PR and no more panics after.
alexcrichton
added a commit
that referenced
this pull request
May 7, 2025
* Skip a test with threads on ASAN (#10728) It's expected that this has memory leaks, there's no clean shutdown in the CLI right now. * Fix missing libcalls with simd float rounding (#10699) This commit fixes some more fallout found on oss-fuzz about the x64 generating rounding builtins when it shouldn't be. This situation is caused by simd float rounding instructions which the x64 backend lowers to libcall-per-element and now needs to move that logic to the frontend instead. * Fix another libcall popping up with simd (#10735) This commit is similar to #10699, another instance of a libcall popping up late in the x64 backend. Fuzzing found this issue and to help verify this is the last one I've run the whole `*.wast` test suite with the x86_64 baseline (no target features) and saw the panic before this PR and no more panics after. * Inline assembler-x64 `generated_files` in `main.rs` (#10739) The public function `generated_files` in `cranelift-assembler-x64` makes the generated `rlib` non-deterministic because it contains the full paths of generated files. But this function is only used in `main.rs` of the same crate, so this change inlines it there to keep the library artifact deterministic while maintaining the same behavior. --------- Co-authored-by: Adam Bratschi-Kaye <adam.bratschikaye@dfinity.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes some more fallout found on oss-fuzz about the x64 generating rounding builtins when it shouldn't be. This situation is caused by simd float rounding instructions which the x64 backend lowers to libcall-per-element and now needs to move that logic to the frontend instead.