capi: Improve header management during build #11961
Open
+8
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the management of header files in cmake to pick up changes to them after-configure in some situations. Previously the cmake scripts would copy all wasmtime headers into the build directory to live adjacent to the `conf.h`-generated header. This meant that there was only one `-I` directory, for example, but it meant that changes to the source files after configuration weren't reflected in the output. This commit fixes this by leaving the source headers in-place. This means that there are now two include directories during building. Various rules/targets should all be updated to handle this, and notably the build script of the C API still copies headers around as it did before (when built via Rust).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the management of header files in cmake to pick up changes to them after-configure in some situations. Previously the cmake scripts would copy all wasmtime headers into the build directory to live adjacent to the
conf.h-generated header. This meant that there was only one-Idirectory, for example, but it meant that changes to the source files after configuration weren't reflected in the output. This commit fixes this by leaving the source headers in-place. This means that there are now two include directories during building.Various rules/targets should all be updated to handle this, and notably the build script of the C API still copies headers around as it did before (when built via Rust).