Add Rust impl of wasmtime_ssp_sched_yield #127

kubkon · 2019-04-28T19:59:51Z

Also, add Rust implementation of errno and convert_errno.

This PR addresses #120.

Caveats:

errno and convert_errno are currently implemented only for *nix OSes (the implementation borrowed from Rust's libstd; please have a look in the comments below)
~~missing handling of EOPNOTSUPP and EWOULDBLOCK~~

All comments and suggestions are more than welcome!

EDIT: to address bindgen issues reported by @heyitsanthony in #126, this PR also manually defines host::__wasi_errno_t errors, and blacklists them in bindgen.

kubkon · 2019-04-28T20:01:49Z

wasmtime-wasi/src/host.rs

+    )]
+    #[cfg_attr(target_os = "haiku", link_name = "_errnop")]
+    fn errno_location() -> *mut libc::c_int;
+}


I couldn't decide between using nix crate or linking to errno ourselves, but in the end, decided to borrow the functionality for *nix directly from Rust's libstd.

We can use the errno crate for cross-platform access to errno (wasmtime uses this in a few other places already).

Ah, nice! I'll investigate today and make amends.

OK, we're now using the errno crate.

kubkon · 2019-04-28T20:02:32Z

wasmtime-wasi/src/host.rs

+        // #endif
+        // #if EWOULDBLOCK != EAGAIN
+        //      [EWOULDBLOCK] = __WASI_EAGAIN
+        // #endif


Not sure how to handle these two cases here. Suggestions more than welcome!

maybe this:

#[allow(unreachable_patterns)] match errno { ... libc::EAGAIN | libc::EWOULDBLOCK => __WASI_EAGAIN, ... }

Perfect, thanks!

I've changed it the way you suggested. I think it looks great now. Have a look and lemme know what you reckon!

Also, add Rust implementation of errno and convert_errno.

sunfishcode · 2019-04-30T05:17:32Z

wasmtime-wasi/src/host.rs

+    )]
+    #[cfg_attr(target_os = "haiku", link_name = "_errnop")]
+    fn errno_location() -> *mut libc::c_int;
+}


We can use the errno crate for cross-platform access to errno (wasmtime uses this in a few other places already).

sunfishcode · 2019-04-30T05:22:51Z

wasmtime-wasi/src/host.rs

+pub const __WASI_ETIMEDOUT: __wasi_errno_t = 73;
+pub const __WASI_ETXTBSY: __wasi_errno_t = 74;
+pub const __WASI_EXDEV: __wasi_errno_t = 75;
+pub const __WASI_ENOTCAPABLE: __wasi_errno_t = 76;


I convinced myself that it's ok to put these here, because eventually, wasmtime_ssp.h and the bindgen-generated wasmtime_ssp.rs will go away and we'll need these :-).

Agreed! :-)

sunfishcode · 2019-04-30T05:30:11Z

wasmtime-wasi/src/host.rs

+pub const __WASI_EXDEV: __wasi_errno_t = 75;
+pub const __WASI_ENOTCAPABLE: __wasi_errno_t = 76;
+
+/// Convert POSIX error to CloudABI error


This comment should now say "... to WASI error".

sunfishcode · 2019-04-30T05:36:55Z

wasmtime-wasi/src/host_impls.rs

+        libc::ENOSYS => host::__WASI_ENOSYS,
+        // TODO: verify if this is correct
+        #[cfg(target_os = "freebsd")]
+        libc::ENOTCAPABLE => host::__WASI_ENOTCAPABLE,


Yes, this is correct, at least at present.

They are now blacklisted in the bindgen.

sunfishcode · 2019-04-30T06:33:36Z

Great!

This commit syncs tests with latest wasmtime revision. As such, it now utilises the `wasmtime-api` crate for runtime setup. Closes #126, #127, #128, #129.

…ocessor processor: update zk processor

This turns the `wasmtime_fibre` into a module called `fibre` in the `runtime` crate. As a result, the `wasmtime_fibre` crate is removed from the workspace. This is helpful for specializing the fibre implementation further for our purposes in the future. Arguably, we could actually make `fibre` a submodule of the existing `continuation` module in `runtime` (i.e., instead of putting it at `wasmtime_runtime::fibre`, put it at `wasmtime_runtime::continuation::fibre`), but I decided against changing the directory structure further for now. The only noteworthy changes outside of moving the files are: 1. The types `SwitchDirection` and `SwitchDirectionEnum`, previously in the `wasmtime_fibre` crate, are now in the `continuations` crate. We need access to these in cranelift. 2. Instead of adding a lot of /// TODO comments I bailed out of mandatory doc comments (as imposed by the `runtime` crate) on pub definitions in the new `fibre` module.

Generate `MovWide` spec. Updates avanhatt#36 avanhatt#35

Verify `load_i64` expansions involving `MovWide` instructions. We added `MovWide` ASLp specs in bytecodealliance#127. This PR provides additional specs to utilize them. Updates avanhatt#49 avanhatt#34

kubkon commented Apr 28, 2019

View reviewed changes

kubkon mentioned this pull request Apr 29, 2019

Replace {environ,size}_{sizes_get,get} C code with Rust #126

Closed

Add Rust impl of wasmtime_ssp_sched_yield

4ce4f9f

Also, add Rust implementation of errno and convert_errno.

sunfishcode reviewed Apr 30, 2019

View reviewed changes

Port host::__wasi_errno_t errors to Rust

55c9d35

They are now blacklisted in the bindgen.

sunfishcode merged commit 86b7a52 into bytecodealliance:master Apr 30, 2019

kubkon pushed a commit that referenced this pull request Nov 7, 2019

Sync with latest wasmtime rev

63c1f71

This commit syncs tests with latest wasmtime revision. As such, it now utilises the `wasmtime-api` crate for runtime setup. Closes #126, #127, #128, #129.

mooori pushed a commit to mooori/wasmtime that referenced this pull request Dec 20, 2023

Merge pull request bytecodealliance#127 from near/viktar/update-zk-pr…

cacbb5f

…ocessor processor: update zk processor

avanhatt pushed a commit to wellesley-prog-sys/wasmtime that referenced this pull request Oct 9, 2024

isaspec: generate MovWide spec (bytecodealliance#127)

7659774

Generate `MovWide` spec. Updates avanhatt#36 avanhatt#35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Rust impl of wasmtime_ssp_sched_yield #127

Add Rust impl of wasmtime_ssp_sched_yield #127

kubkon commented Apr 28, 2019 •

edited

Loading

kubkon Apr 28, 2019

sunfishcode Apr 30, 2019

kubkon Apr 30, 2019

kubkon Apr 30, 2019

kubkon Apr 28, 2019

heyitsanthony Apr 29, 2019

kubkon Apr 29, 2019

kubkon Apr 29, 2019 •

edited

Loading

sunfishcode Apr 30, 2019

sunfishcode Apr 30, 2019

kubkon Apr 30, 2019

sunfishcode Apr 30, 2019

kubkon Apr 30, 2019

sunfishcode Apr 30, 2019

kubkon Apr 30, 2019

sunfishcode commented Apr 30, 2019

Add Rust impl of wasmtime_ssp_sched_yield #127

Add Rust impl of wasmtime_ssp_sched_yield #127

Conversation

kubkon commented Apr 28, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kubkon Apr 29, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sunfishcode commented Apr 30, 2019

kubkon commented Apr 28, 2019 •

edited

Loading

kubkon Apr 29, 2019 •

edited

Loading