Exit with a more severe error code if the program traps. #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhuene
approved these changes
Mar 10, 2020
fitzgen
reviewed
Mar 10, 2020
src/commands/run.rs
Outdated
| // than a simple failure. | ||
| if let Some(source) = e.source() { | ||
| if let Some(source) = source.source() { | ||
| if source.is::<Trap>() { |
There was a problem hiding this comment.
Rather than hard-coding "check for a trap two error sources above this error in the chain" I think it would make sense to loop over the whole chain and check for if any of them is a trap. Does that make sense?
There was a problem hiding this comment.
let mut err = Some(&e);
while let Some(source) = err {
if source.is::<Trap>() { ... }
err = source.source();
}There was a problem hiding this comment.
Makes sense to me! I've now added a patch to do that. I just had to make a slight tweek, since e here is an anyhow::Error, so we have to start with the first source() rather than starting with e.
fitzgen
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
Looks great! FWIW, I forgot that anyhow has an iterator to do this already, so we could skip the while let if we want: https://docs.rs/anyhow/1.0.26/anyhow/struct.Chain.html
alexcrichton
approved these changes
Mar 11, 2020
|
Test added! |
Previously, the wasmtime CLI would return with a regular failure error code, such as 1 on Unix. However, a program trap indicates a bug in the program, which can be useful to distinguish from a simple error status. Check for the trap case, and return an appropriate OS-specific exit status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the wasmtime CLI would return with a regular failure
error code, eg. 1 on Unix. However, a program trap indicates a bug in
the program, which can be useful to distinguish from a simple error
status. Check for the trap case, and return an appropriate OS-specific
exit status.