Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove support for interface types #1292

Merged
merged 2 commits into from
Mar 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ doc = false
wasmtime = { path = "crates/api" }
wasmtime-debug = { path = "crates/debug" }
wasmtime-environ = { path = "crates/environ" }
wasmtime-interface-types = { path = "crates/interface-types" }
wasmtime-jit = { path = "crates/jit" }
wasmtime-obj = { path = "crates/obj" }
wasmtime-profiling = { path = "crates/profiling" }
Expand Down
22 changes: 22 additions & 0 deletions crates/api/src/module.rs
Original file line number Diff line number Diff line change
Expand Up @@ -418,6 +418,28 @@ impl Module {
}
}
}
SectionCode::Custom {
name: "webidl-bindings",
..
}
| SectionCode::Custom {
name: "wasm-interface-types",
..
} => {
bail!(
"\
support for interface types has temporarily been removed from `wasmtime`
alexcrichton marked this conversation as resolved.
Show resolved Hide resolved

for more information about this temoprary you can read on the issue online:
alexcrichton marked this conversation as resolved.
Show resolved Hide resolved

https://github.com/bytecodealliance/wasmtime/issues/1271

and for re-adding support for interface types you can see this issue:
alexcrichton marked this conversation as resolved.
Show resolved Hide resolved

https://github.com/bytecodealliance/wasmtime/issues/677
"
);
}
_ => {
// skip other sections
}
Expand Down
25 changes: 0 additions & 25 deletions crates/interface-types/Cargo.toml

This file was deleted.

4 changes: 0 additions & 4 deletions crates/interface-types/README.md

This file was deleted.

Loading