Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WASI-tutorial.md #162

Merged
merged 3 commits into from
Jun 19, 2019
Merged

Conversation

Gregoirevda
Copy link
Contributor

Extend doc on how to compile

docs/WASI-tutorial.md Show resolved Hide resolved
```

The sysroot is folder is located in `opt/wasi-sdk/share/sysroot/`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, depending on whether 1) you're using the wasi-sdk, or 2) stock clang-8 with wasi-sysroot, the path doesn't have to be opt/wasi-sdk/share/sysroot. It is true however that by default on Linux, wasi-sdk installs into /opt/wasi-sdk/share/sysroot, but not necessarily if using the second option. Like above perhaps it'd be better to explain that to the potential reader?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this path recently changed, to /opt/wasi-sdk/share/wasi-sysroot; would you mind updating the PR here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunfishcode this is not released yet right? So I'll stick to opt/wasi-sdk/share/sysroot/ for now

@Gregoirevda
Copy link
Contributor Author

I'll change it to macos specific compilation. Would have helped me, so I think others too :)

Update README based on feedback
@Gregoirevda
Copy link
Contributor Author

Anything still to update?

@sunfishcode
Copy link
Member

Looks good, thanks!

@sunfishcode sunfishcode merged commit d900a5f into bytecodealliance:master Jun 19, 2019
pchickey added a commit to pchickey/wasmtime that referenced this pull request May 16, 2023
…ffold_host_p1

scaffold out preview 1 support
dhil added a commit to dhil/wasmtime that referenced this pull request May 1, 2024
avanhatt pushed a commit to wellesley-prog-sys/wasmtime that referenced this pull request Oct 18, 2024
Verify `imul`, `smulhi` and `umulhi` rules.

Updates avanhatt#34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants