-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WASI-tutorial.md #162
Conversation
docs/WASI-tutorial.md
Outdated
``` | ||
|
||
The sysroot is folder is located in `opt/wasi-sdk/share/sysroot/`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, depending on whether 1) you're using the wasi-sdk, or 2) stock clang-8
with wasi-sysroot, the path doesn't have to be opt/wasi-sdk/share/sysroot
. It is true however that by default on Linux, wasi-sdk
installs into /opt/wasi-sdk/share/sysroot
, but not necessarily if using the second option. Like above perhaps it'd be better to explain that to the potential reader?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this path recently changed, to /opt/wasi-sdk/share/wasi-sysroot
; would you mind updating the PR here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sunfishcode this is not released yet right? So I'll stick to opt/wasi-sdk/share/sysroot/
for now
I'll change it to macos specific compilation. Would have helped me, so I think others too :) |
Update README based on feedback
consistent
Anything still to update? |
Looks good, thanks! |
…ffold_host_p1 scaffold out preview 1 support
Verify `imul`, `smulhi` and `umulhi` rules. Updates avanhatt#34
Extend doc on how to compile