Print correct version of bin tools #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not something important, but I use these tools for some testing and they print wrong version with --version flag.
let version = env!("CARGO_PKG_VERSION"); |
Thanks, did fix to use it. |
bjorn3
reviewed
Jul 3, 2019
bjorn3
approved these changes
Jul 3, 2019
|
Looks good to me too! |
grishasobol
pushed a commit
to grishasobol/wasmtime
that referenced
this pull request
Nov 29, 2021
…ealliance#187) * Remove hashbrown and use BTree{Map,Set} from the alloc crate wasmi-validation must handle untrusted input and hence we switch from Hash{Set,Map} (whether std's or hashbrown's) to BTree{Set,Map} to avoid algorithmic complexity attacks while retaining no_std support. Closes bytecodealliance#183 * Improve memory locality of checking for duplicate exports Using a sorted slice gives us the same O(N log N) worst case execution time as using a BTreeMap, but using a single allocation as with HashMap, so that we should see better memory locality and hence better constant factors when checking for duplicate exports.
dhil
added a commit
to dhil/wasmtime
that referenced
this pull request
May 27, 2024
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Oct 23, 2024
Verifies the `iadd_extend_*` rules. The main challenge here was specifying the `extended_value_from_value` extractor which is polymorphic on its input and output widths. Updates avanhatt#34
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Oct 23, 2024
Verifies the `iadd_extend_*` rules. The main challenge here was specifying the `extended_value_from_value` extractor which is polymorphic on its input and output widths. Updates avanhatt#34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not something important. But if needed, I changed the version to the correct one specified in Cargo.toml. I use these tools for some testing and they print wrong version with --version.