Fix and enable GC on new x64 backend. #2410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One critical bit of plumbing was missing: the `StackMapSink` passed to `compile_and_emit` was not actually receiving stackmaps. This seemingly very basic issue was not caught because the other major user of reftype support, SpiderMonkey, extracts stackmaps with a lower-level API. The SM integration was built this way to avoid an awkward API quirk when passing stackmaps through a `CodeSink` that proxies them to a `StackMapSink`: the `CodeSink` wants `Value`s for each reference slot, while the actual `StackMapSink` does not require these. This PR tweaks the plumbing in a slightly different way to make `wasmtime` GC tests, and presumably other consumers of stack-map info from the top-level Cranelift interface, happy.
|
This addresses one of the items in #2079. |
github-actions
bot
added
the
cranelift
yurydelendik
approved these changes
Nov 13, 2020
This was referenced Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One critical bit of plumbing was missing: the
StackMapSinkpassed tocompile_and_emitwas not actually receiving stackmaps. This seeminglyvery basic issue was not caught because the other major user of reftype
support, SpiderMonkey, extracts stackmaps with a lower-level API. The
SM integration was built this way to avoid an awkward API quirk when
passing stackmaps through a
CodeSinkthat proxies them to aStackMapSink: theCodeSinkwantsValues for each reference slot,while the actual
StackMapSinkdoes not require these. This PR tweaksthe plumbing in a slightly different way to make
wasmtimeGC tests,and presumably other consumers of stack-map info from the top-level
Cranelift interface, happy.