Update the C API with module linking support #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
alexcrichton
added a commit
to alexcrichton/wasmtime-py
that referenced
this pull request
Dec 3, 2020
This updates the Python extension with the API support added in bytecodealliance/wasmtime#2472. Most of the changes here were pretty straightforward!
|
It's worth noting that I tested this against bytecodealliance/wasmtime-py#47 as well to ensure it doesn't at least immediately segfault. |
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:c-api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This commit does everything necessary (ideally) to support the module
linking proposal in the C API. The changes here are:
* New `wasm_{module,instance}type_t` types and accessors
* New `wasm_{module,instance}_type` functions
* Conversions between `wasm_extern_t` and `wasm_{instance,module}_t`, as
well as `wasm_externtype_t` and the new types.
* Addition of `WASM_EXTERN_{MODULE,INSTANCE}` constants
* New `wasm_config_t` modifier to enable/disable module linking
With these functions it should be possible to pass instances/modules to
instances and also acquire them from exports. Altogether this should
enable everything for module linking.
An important point for this is that I've opted to add all these items
under the `wasm_*` name prefix instead of `wasmtime_*`. I've done this
since they're all following the idioms of existing APIs and while not
standard the intention would be to standardize them (unlike many other
Wasmtime-specific APIs).
cc bytecodealliance#2094
alexcrichton
force-pushed
the
module-linking-c-api
branch
from
e8bd432 to
c3a1427
Compare
peterhuene
approved these changes
Dec 3, 2020
alexcrichton
added a commit
to bytecodealliance/wasmtime-py
that referenced
this pull request
Dec 3, 2020
This updates the Python extension with the API support added in bytecodealliance/wasmtime#2472. Most of the changes here were pretty straightforward!
alexcrichton
added a commit
to alexcrichton/wasmtime-go
that referenced
this pull request
Dec 3, 2020
This commit binds the support added in bytecodealliance/wasmtime#2472 to bring support for the module linking to this Go extension. The support here is similar to bytecodealliance/wasmtime-py#47, which is hooking up modules/instances to `Extern` as well as adding dedicated instance/module types.
alexcrichton
added a commit
to bytecodealliance/wasmtime-go
that referenced
this pull request
Dec 4, 2020
* Implement module linking proposal This commit binds the support added in bytecodealliance/wasmtime#2472 to bring support for the module linking to this Go extension. The support here is similar to bytecodealliance/wasmtime-py#47, which is hooking up modules/instances to `Extern` as well as adding dedicated instance/module types. * Update bazel build * Try to fix a Windows CI issue
X-leaf7
added a commit
to X-leaf7/wasmtime-go
that referenced
this pull request
Jun 24, 2024
* Implement module linking proposal This commit binds the support added in bytecodealliance/wasmtime#2472 to bring support for the module linking to this Go extension. The support here is similar to bytecodealliance/wasmtime-py#47, which is hooking up modules/instances to `Extern` as well as adding dedicated instance/module types. * Update bazel build * Try to fix a Windows CI issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does everything necessary (ideally) to support the module
linking proposal in the C API. The changes here are:
wasm_{module,instance}type_ttypes and accessorswasm_{module,instance}_typefunctionswasm_extern_tandwasm_{instance,module}_t, aswell as
wasm_externtype_tand the new types.WASM_EXTERN_{MODULE,INSTANCE}constantswasm_config_tmodifier to enable/disable module linkingWith these functions it should be possible to pass instances/modules to
instances and also acquire them from exports. Altogether this should
enable everything for module linking.
An important point for this is that I've opted to add all these items
under the
wasm_*name prefix instead ofwasmtime_*. I've done thissince they're all following the idioms of existing APIs and while not
standard the intention would be to standardize them (unlike many other
Wasmtime-specific APIs).
cc #2094