Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Windows, ignore files for which full_metadata fails. #2884

Merged

Commits on May 7, 2021

  1. On Windows, ignore files for which full_metadata fails.

    On Windows, `metadata` computes only partial metadata results, which don't
    include what WASI needs for the `inode` field in `readdir` results. cap-std
    has a `full_metadata` function which is able to include this extra
    information, however it has more strict access requirements, so it sometimes
    fails even when plain `metadata` would succeed.
    
    Make WASI's `readdir` silently skip over files that can't be accessed by
    `full_metadata`. These files wouldn't be openable in any other way by
    WASI programs, so the only benefit of listing them would be to
    let applications know that they exist. This allows it to avoid failing
    and avoid returning bogus results.
    
    This is part of a fix for bytecodealliance/cap-std#169.
    sunfishcode committed May 7, 2021
    Configuration menu
    Copy the full SHA
    6ba5e16 View commit details
    Browse the repository at this point in the history