CI: put tests into a separate script so they can be run externally #2956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
alexcrichton
reviewed
Jun 1, 2021
ci/run-tests.sh
Outdated
|
|
||
| cargo test \ | ||
| --features "test-programs/test_programs" \ | ||
| $EXTRA_FEATURE \ |
There was a problem hiding this comment.
Could this perhaps be "$@" to just forward all arguments to cargo test (and placed at the end). That way the --locked could also be passed in only with CI to make this a bit more useful to run locally.
There was a problem hiding this comment.
Good idea, it's also more future-proof!
alexcrichton
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This streamlines running the tests, and has the benefits to make it trivial to locally run tests as they're run in CI (viz. use
./ci/run-tests.sh) and makes thecargo testflags uniform across testing, including for theold-x86-backend.