Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to cache typechecking an instance #2962

Merged
merged 2 commits into from
Jun 3, 2021
Merged

Add the ability to cache typechecking an instance #2962

merged 2 commits into from
Jun 3, 2021

Commits on Jun 3, 2021

  1. Add the ability to cache typechecking an instance 

    This commit adds the abilty to cache the type-checked imports of an
instance if an instance is going to be instantiated multiple times. This
can also be useful to do a "dry run" of instantiation where no wasm code
is run but it's double-checked that a `Linker` possesses everything
necessary to instantiate the provided module.

This should ideally help cut down repeated instantiation costs slightly
by avoiding type-checking and allocation a `Vec<Extern>` on each
instantiation. It's expected though that the impact on instantiation
time is quite small and likely not super significant. The functionality,
though, of pre-checking can be useful for some embeddings.
    @alexcrichton
    alexcrichton committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    87acdb2 View commit details
    Browse the repository at this point in the history

  2. Fix build with async

    @alexcrichton
    alexcrichton committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    20fcb34 View commit details
    Browse the repository at this point in the history